Roman Artiukhin

Ok. I rebased it on top of master. I would prefer to fix it in 5.4 one way or another. So let it hang till we decide what should we...

I just tried to regen async code just in case and it seems it's utterly broken on my machine. Throws some random exceptions when processing NHibernate.Test project like `symbol for...

It's not a regression so it's not applicable for 5.3 branch. You should target master branch. And master SQL syntax problem needs to be investigated anyway.

I believe I fixed issue with invalid SQL syntax on master in #3106. I also reproduced your issue using existing test data (see `JoinedSubclassFilterTest.FilterCollectionWithSubclass2`)

I don't think it's by design - simply not implemented. My guess it would work parametrized: ```C# var v = 1; var jk = session.QueryOver().Where(x => v == 1).Take(1); ```

TBH I don't like this change. All these checks just to throw not NRE but different kind of exception feels like not useful change that unnecessarily clutters the code. So...

> And what about the read-write case Sorry I don't know this part of code - so have no idea what would fail on its disposed lock and in which...

> It should be validated or rejected I still think the issue is not worth changes made in this PR. And it shouldn't hold the release - this PR can...

This PR just changes one exception with another. It doesn't fix anything. So it won't help you > Can you please expand on invalid usage scenario https://github.com/nhibernate/nhibernate-core/issues/2530#issuecomment-691234620 So if you...

> Why not just ORDER BY 1 I don't like it. How is it better? It looks hackish to me...