Roman Artiukhin

Results 168 comments of Roman Artiukhin

> .Where(f => names.Where(d => d != null).Contains(f.Name)) Are you sure that this `Where` part is actually executed in 5.2. According to #2276 I expect Where part to be ignored...

> Copy full code of re-linq into NHibernate. Cleanup, remove custom duplicates, etc. This has happened in the past with LinFu proxy and logging. Thought of suggesting it myself. Totally...

Yeah. Dependency on nuget looks like unnecessary complication in this case. Maybe we should still make a fork but make it part of NHibernate solution using [git submodule](https://git-scm.com/docs/gitsubmodules)

> The second proposition, incorporating the source code, has the same two drawbacks, does it not? How it applies to `we will be constrained by the semver changes`? Yes -...

Just a guess... Do you have `proxyfactory.factory_class` session factory setting set? If yes - try to remove it. If not - try to set it to `NHibernate.Bytecode.DefaultProxyFactoryFactory` (which is despite...

Does serialization work properly with manually created and populated list? Something like: ```C# var newObj = new MyClass(); newObjc.Collection = new List(); newObj.Collection.Add(new Child()); serializer.WriteObject(wcfMessage ,newObj); ```

I think it should be closed as external issue because of: > I go back to the last working version (4.1.1) and lol... don't work too... Something broken during update....

My guess it's caused by https://github.com/nhibernate/nhibernate-core/pull/2737 (at least newly added `GroupJoinAggregateDetectionQueryModelVisitor` is part of exception stacktrace)

> The issue is 'where customerco3_.is_ready' block. I don't get this part. Provided exception suggests that it throws before SQL execution (it fails when SQL is not even generated).

Suggested fix looks acceptable to me.