Roman Artiukhin

Results 168 comments of Roman Artiukhin

Hm.. All of these methods generate `HqlLike` node. So parameter detection implemented in https://github.com/nhibernate/nhibernate-core/blob/74b97af3474d42311a46dd6ec832a11ddf7ae689/src/NHibernate/Hql/Ast/ANTLR/Tree/BinaryLogicOperatorNode.cs#L56-L66 should handle and apply proper parameter type (where `lhs` is mapped property with known type, and...

Oups.. Without guessing parameter detection only properly works for `Like`. It's still broken for StartsWith and other methods.

For possible fix see https://github.com/nhibernate/nhibernate-core/pull/2793#issuecomment-851673251

> Is there any workaround? Adding explicitly order by clause to query: ```sql select distinct p from Person p order by p.id desc ```

I believe it would also need changes similair to https://github.com/nhibernate/nhibernate-core/pull/2836

> please resolve conflicts. Also as I understand some changes needs to be reverted from 5.3.9 Done

It seems some of the changes no longer needed. I need to look at it more closely when I have time...

#2964 implements most of the logic of original PR. Now this PR is transformed in parameter handling improvement so changed the name.

From https://github.com/nhibernate/nhibernate-core/pull/2966#discussion_r777159675: > + behaves differently than || and requires explicit conversion to string first. It should be ||, but then definition becomes the same as in base dialect. So...

> The agent is back online, but now it is not authorized :( It seems all you have to do is to click Authorize on this page https://teamcity.jetbrains.com/agents.html?tab=unauthorizedAgents (I see...