Alex Beregszaszi

Results 655 comments of Alex Beregszaszi

Why would it be different? This is the documentation we have for this format: http://solidity.readthedocs.io/en/develop/abi-spec.html#non-standard-packed-mode Do you have some test cases which triggers this in Solidity?

I wonder if it would be better to instead require a `Buffer` for bytes and let the caller make the decision?

@VoR0220 what is the problem this is solving?

I think the main motivation was not require strict inputs and not introduce the mess other ethereumjs libraries have with the `toBuffer` function, which just hides a bunch of different...

Sorry @niran I am not sure exactly which types this is an issue with? Would you mind posting some examples?

@niran those aliases are implemented. Where are you getting an error?

@niran apparently `byte` is a new addition as hence it is not included. It needs to go into the ABI first, but happy to support it after.

@niran the translation is done earlier: https://github.com/axic/ethereumjs-abi/blob/master/lib/index.js#L178 and https://github.com/axic/ethereumjs-abi/blob/master/lib/index.js#L217 It should be `(u)int256` by the time it gets into the single item encoding

cc @tinybike @wanderer

The ABI JSON makes it easy to support overloading for encoding, e.g. if the ABI defines `someMethod` with both `bytes` and `uint` as an input, `encode()` could decide which one...