Alex Beregszaszi
Alex Beregszaszi
@dcousens do you think it would make sense revisiting this PR?
Some of the things you've mentioned could be addressed/discussed as part of #129: > toString(16) seems to output unsigned hex string with a - sign appended to the front. >...
I think technically works (but would need a rebase and confirming it still works), however perhaps the gain wasn't significant enough at the time? If there's interest getting this merged,...
These tests actually fail, because contrary to the name, the code seems to be rounding to ceiling. Is it supposed to be like that? This was my first step at...
Towards zero for negatives.
I don't particularly have a lot of time, but I guess this PR could be changed to add tests for the current behaviour and update documentation to reflect that. A...
Perhaps the benchmarks aren't the best. The code is: ``` js var x = new bn(13); add('pow', { 'bn.js pow': function (fixture) { fixture.a1.clone().pow(x); }, 'bn.js ipow': function (fixture) {...
I wonder how much safety this would actually provide given the interpreted/JITed nature of Javascript?
I also propose to create a `v5.x` branch to merge these changes in.
Perhaps also the following could be discussed as part of this: - #79 - #107