ethereumjs-abi icon indicating copy to clipboard operation
ethereumjs-abi copied to clipboard

Published 20 hours ago • verified publisher icon ethereumjs

Allow using '0x...' as input value for bytes

Open yann300 opened this issue 6 years ago • 5 comments

yann300 avatar Oct 08 '17 11:10 yann300

Coverage Status

Coverage increased (+2.04%) to 85.757% when pulling 08593a3b8df281ae67019faf2eff693e81887b87 on yann300:fixEncodingBytes into ee6ded67235a98f3ef4ae2a338aee70a9f68fe20 on ethereumjs:master.

coveralls avatar Oct 08 '17 12:10 coveralls

I wonder if it would be better to instead require a Buffer for bytes and let the caller make the decision?

axic avatar Dec 06 '17 11:12 axic

That would break project that already use it (Mist?) . But I am fine with it .. that is cleaner anyway

yann300 avatar Dec 06 '17 13:12 yann300

That's also very convenient to be able to input a hex string (specially when you have to deal with arrays...) what do you want to do with this one? cause it leads to a very nasty bug in Remix...

yann300 avatar Dec 07 '17 17:12 yann300

@axic State of discussion in this PR is also unclear, needs further clarification.

holgerd77 avatar Sep 21 '18 12:09 holgerd77