Alex Beregszaszi
Alex Beregszaszi
@dcousens luckily I am not dealing with ASN.1. `toTwos`/`fromTwos` is used within https://github.com/ethereumjs.
@indutny I'd pretty much like `modn` to return a BN but take a Number if possible
Here was another potential thing: Rename `toJSON`, see https://github.com/indutny/bn.js/pull/164#issuecomment-303332320
Never mind, I've only realised now that `toJSON` is potentially used by `JSON.stringify` and it should have no other use beyond that. Perhaps documenting this would be enough. See [this](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#toJSON()_behavior).
Reviewing the release, it seems that #112 could have been more clear. Perhaps for the 6.x release then 😉
Or instead of the assertion, it could have a conditional `if (num >= 0x4000000) return iadd(new BN(num))`
I'd like to reopen this. We found a need for `divCeil` in ethereumjs. This is the current code we have: ``` +// Find Ceil(`this` / `num`) +BN.prototype.divCeil = function divCeil...
@kvhnuke you could even use the standard V3 keystore format with lower scrypt settings (or even PBKDF2 and still be better than EVP). It uses aes-128-ctr as default. These are...
Would it make sense extending this to have an optional *default* value? I am in the process of porting over a project from jsoncpp to nlohmann-json, and the former has...
@nlohmann oh wow, that certainly looks like it, thank you!