Ary Borenszweig

Results 414 comments of Ary Borenszweig

I think back then I checked against the null byte just because I didn't think of a use case for having null bytes. But I don't see anything wrong with...

Maybe we can remove the `spec` command? Or deprecate it... It only exists so you can pass a filename with a line number, like `crystal spec file.cr:22`. Instead, we could...

@txe Please coordinate with @RX14 , as far as I know he was porting File to Windows (not sure about Dir). For UTF16 we now have this: https://github.com/crystal-lang/crystal/pull/5541 . But...

In fact, since none of this will "matter" until we can bootstrap the compiler in Windows, I would prefer small PRs that do some small functionality, even if incomplete. Then...

I just don't think this is an existing pain point.

Manas is already using Google Analytics for this and they probably can compare view history over time without changing things. And the only ones who gets a benefit with this...

Another suggestion which might be better is to move this to the standard library, maybe inside `HTTP::Client::Mock`, because every time a new Crystal version is released this shard breaks, the...

Yes, I think webmock and time.mock should be in the standard library, because they are coupled with their interface/definition. We'll eventually do it (though it will probably be called `HTTP::Client::Mock`)

I think those functions were unknown to the implementors.

> I could see maybe always promoting to the larger type of the two? Or is that too confusing? It's the same problem I describe but worse, because right now...