Ary Borenszweig
Ary Borenszweig
I tried changing this and there are a lot of changes to do in the stdlib already. So this is probably very difficult/tedious to change and might not be worth...
Filtering methods in a derived class's macro can result in empty MacroIds if splatted in a push call
The problem is that the splat operator doesn't work in macro calls. I forgot to implement this (Oops!). Right now `*` (splat) will turn antyhing into a macro id of...
Filtering methods in a derived class's macro can result in empty MacroIds if splatted in a push call
Also `push` in macros just accepts one argument, so that would have to be fixed too...
These were never discussed before, sorry. I don't understand their usefulness so I won't approve them.
Can you provide a use case? Also, UInt16 should be replace with Int32. Then, I don't understand why names is useful for, and why there needs to be an unsorted...
Sorry, I don't have much more time to review or decide things.
What if we also consider class methods that yield an instance of a type to be constructors?
Duplicate of https://github.com/crystal-lang/crystal/pull/8990?
I found another optimization that improved both speed of parsing and the memory it allocates. [This PR](https://github.com/crystal-lang/crystal/pull/10447) made parsing slower by always allocating a string to parse integers and floats...
I think one of the "peek" branches is wrong. I'll see if I can merge it. I don't have a test to reproduce it yet, just one scenario I ran...