Ary Borenszweig comments

Results 414 comments of


                                            Ary Borenszweig

Premature closure of a class can be missed because many class operations are valid at top-level

See https://github.com/crystal-lang/crystal/pull/10019

Premature closure of a class can be missed because many class operations are valid at top-level

> However, it's just passed a lot of stuff that shouldn't have meaning at top-level But defining methods at the top-level is fine. The above snippet is perfectly valid. That's...

crystal tool format no-op if indentation error on macro

I guess, if a macro consist exactly of a series of MacroLiterals but without any expressions in them, we could turn that into a String, parse it, then format it.

Fresh variables example doesn't work anymore.

It's just a bug in the compiler. Some code was added to correctly parse `"...%s..."` inside string literals and that broke this.

Interpreter: Process#run broken with defunct child process

Fork in interpreted mode is broken and I don't understand why yet. I debugged this a lot in the past. This will likely not be fixed any time soon.

Interpreter: Process#run broken with defunct child process

It's because there's something wrong in the way `fork` is executed in the interpreter. And it's really hard to debug. To begin with, we should start finding out why this...

Interpreter: Process#run broken with defunct child process

Cool! What happens if you run this code with the interpreter? ```crystal loop do puts `ls` end ```

Interpreter: Process#run broken with defunct child process

Thanks for the investigation! I don't think I'll have time to look at this. But the gist is: if it works with the GC disabled, then it definitely **doesn't work**....

Re runs all previous commands generates unexpected results

@owen2345 Could you explain how this will work when a variable is, for example, a file that points to an open file descriptor? The file descriptor will be gone. You...

Re runs all previous commands generates unexpected results

Also not every type is JSON serializable. Finally, I saw you posted a request on the forums to get the local vars. You don't need that in the compiler. You...