Ary Borenszweig
Ary Borenszweig
Can you benchmark the difference? Creating a MemoryIO allocates memory so this should result in a slowdown. The idea is good, but I wouldn't merge this if it makes things...
I mean, creating the MemoryIO is what allocates memory. Maybe it's insignificant, though, but I don't know.
@miketheman It's in https://github.com/will/crystal-pg/blob/master/src/pg/decoder.cr Every postgres type has an ID, called `oid`. A decoder can handle a series of `oid`s. So my guess is that you'll need to define a...
I wonder whether some types should be automatically casted if there is no precision loss. That means if you do `rs.read(Int32)` and the underlying type is `Int8`, `Int16` or `Int32`...
Yes, please send PR with these additions :-)
@datanoise @bararchy Of course, take your time, there's absolutely no rush in any of this. And big thanks for the help! :-)
Why can't this be in another gem? I don't think it's a good practice to include Rails stuff everywhere. For example, I plan to use this gem in a project....
Good find. I'll try to think of a solution. Maybe always using downcase for the names is not good.
With @waj we were thinking how to have a decentralized approach by maybe leaving a shard's metadata in a special branch in the repository. That metadata would contain a special...
As for @zamith's concern about a registry, maybe we can have the registry just be a website that scans GitHub/BitBucket for crystal-related projects that have that special branch with the...