Anton Korobeynikov comments

Results 791 comments of


                                            Anton Korobeynikov

Do not recalculate refmap so often

https://github.com/p4lang/p4c/pull/4757 is a working PR accumulating required changes

[RFC] Make cstring constructor from `char*` explicit and `string_view` conversion implicit

Tagging @vlstill @fruffy @ChrisDodd for opinions

[RFC] Make cstring constructor from `char*` explicit and `string_view` conversion implicit

> @vlstill also introduced a `_cs` suffix at some point which should help here? #4342 Yes. `_cs` would reduce the amount of typing indeed. As far as I can see,...

[RFC] Make cstring constructor from `char*` explicit and `string_view` conversion implicit

@vlstill Yeah. That's lots of work. I already started changes here and there. Some observations: - There are lots of `cstring`'s created from string literals. Here `_cs` is a rescue....

[RFC] Make cstring constructor from `char*` explicit and `string_view` conversion implicit

So, I just moved a downstream backend over the changes in https://github.com/p4lang/p4c/pull/4694 It was not that painful. Important story that it uncovered lots of rusty cruft accumulated over the time:...

[RFC] Make cstring constructor from `char*` explicit and `string_view` conversion implicit

Some story from dowstream code. It had code like this: ```c++ void foo(cstring a, cstring b, ...); void bar() { .. std::string s = a->toString().c_str(); if (rare_condition) s += prefix;...

Reduce type checking overhead

Tagging @ChrisDodd

[PAC][Driver] Implement `-mbranch-protection=pauthabi` option

> Is there any thought on how we want to manage signing schemas going forward? For example I can imagine looking an environment from the triple to select a signing...

[PAC][Driver] Implement `-mbranch-protection=pauthabi` option

Thanks @smithp35 I opened https://github.com/llvm/llvm-project/issues/99950 to track this

error while parsing GFA path record

You need to use the latest BinSPreader that is capable of reading GFA v1.2 files. Alternatively, if upgrading BinSPreader is not an option, you can emit graphs in old GFA...