Anton Korobeynikov comments

Results 791 comments of


                                            Anton Korobeynikov

[EraVM][MC] Add missing variants of NOP instruction

Looks reasonable to me. @sayon Will you please check the desired syntax in the tests?

[MC][AsmParser] Rename mnemonics according to the specification

We will wait for the updated ISA spec to perform the rename

[MC][AsmParser] Rename mnemonics according to the specification

@akiramenai @hedgar2017 @sayon So, what is the ultimate resolution on the assembler syntax from 1.6 ISA spec? For example https://matter-labs.github.io/eravm-spec/spec.html#NearRetDefinition says: ``` Syntax ret in1 Legacy syntax ret.ok aliased as...

[MC][AsmParser] Rename mnemonics according to the specification

@sayon Please check the question above

[MC] Refine Near / Far Ret / Revert / Panic

@atrosinenko Is this done?

[LLD] Provide meaningful default linker script

Tagging @PavelKopyl

I introduced that duplication because I had issues with `OperandAddrMode` as the ColField. As you refactor our `td`s anyway, may I ask if it's hard to get rid of `OperandAM`?

@akiramenai Will you please take a look? Is this something you had in mind?

tc / ebpf backends use unparsed annotations

See https://github.com/p4lang/p4c/pull/5018/files#diff-2494735621545235a407b7a74124268ece6ec99bc8f55a5a581675771e3c0114R208

DefUse is consuming lots of memory

Tagging @ChrisDodd Is there something that could be improved? Could midend def-use be reused if it has better performance?

DefUse is consuming lots of memory

Allocation tracing looks like as follows: ```log Allocated a total of 3.6GB memory allocated 1.7GB in 15321 calls from: 4 p4c 0x0000000102c7d678 _ZN2P49Inspector13apply_visitorEPKNS_2IR4NodeEPKc + 636 0x102c7d678 3 p4c 0x0000000102aa84bc _ZN2P415ComputeWriteSet8preorderEPKNS_2IR19AssignmentStatementE...