Anton Korobeynikov

Results 825 comments of Anton Korobeynikov

This is very large dataset, so many things could go wrong... Does it work smaller / subsampled dataset? You might also want to do some quality trimming and try `--only-assembler`

Hello It seems your output directory is on some removable storage and the file system there does not allow special symbols in paths (e.g. ">" or "=" like here). I...

> I am also not sure this is a good idea. Of course, the compiler should not crash, but I am not sure implicit comparison of two different enum types...

I am afraid we really do not think we're interested in introducing this kind of breaking changes. As you mentioned, these are invasive, will be constantly broken, require explicit conversions,...

> Is there no way we can provide libs/binaries with absl and protobuf statically compiled/linked to work around this issue? The problem with Debian is also that some of these...

> But p4c does use string_view as return types in a lot of places. Do you have any mechanisms in place to keep it safe? Frankly speaking, I do not...

@ChrisDodd Is this going to support also aliasing cases at the caller side? E.g. ```p4 struct S { bit field } action foo(inout S, out bit) { ... } S...

> I think that should already be an error -- using the same object for two different out or inout args in the same call. I might be missing something,...

> I really don't like allowing multiple writes to the same object in a single call, even though the spec has been worded to allow it. IMO that's s spec...

> `-fstrict-aliasing` in C/C++ just allows the compiler to assume that lvalues of different types don't alias. Since we don't have pointers or pointer casts in P4, there is no...