Alexis Arnaudon
Alexis Arnaudon
thanks @adrien-berchet , @lidakanari can we merge this?
it is passed via parameters file
is `pia` bothering you? its legacy, I'm to lazy to change its name
@lidakanari so I did a complete refactoring, it was indeed not making so much sense. I did the following: - renamed PIA_DIRECTION to Y_DIRECTION - renamed pia_direction to y_direction -...
@adrien-berchet , when you have 5min, if you can take a look at this to see if the general implementation makes sense. I will then use context to modify the...
@lidakanari @adrien-berchet , this can be reviewed as well, again, it is experimental, so not fully tested
I'm not sure which 'core functionalities' you are mentioning? its all under ```if self.context is not None``` no?
What would be your suggestion to improve then? I don't mind leaving this open for ever, it does the job I need it to do with the other open PR...
I can try to add a couple more tests, but this code is not meant to be use 'directly'. There is no probability function implemented here, it has to be...
@adrien-berchet , I'll look at you suggestion soon, clean up a few things and check the tests maybe later this week