arkon

Results 201 comments of arkon

onClickedOutside is dispatched on routerLink click

Sorry, the Plunkr doesn't seem to work?

onClickedOutside is dispatched on routerLink click

Ah nevermind, I think uBlock was preventing it from working. I'll check this out when I have time.

feat: upgrade to Angular 13 and support its modern package format

Thanks for taking the time to contribute, but I've decided to stop maintaining this package. For more details, check out https://github.com/arkon/ng-sidebar/issues/229 If you're interested in maintaining a fork, please do...

Passive

It is possible to add. A PR would be welcomed.

Passive

> Do you have a contribution guide anywhere. I don't. You can refer to the scripts within `package.json`. You can also test it with the demo app in `/demo`.

Allow to exclude all child elements of an element

Why not just make the selector include children?

Allow to exclude all child elements of an element

I mean something like `.ancestor *`.

Uncaught Error: Type ClickOutsideModule does not have 'ngModuleDef' property.

You'd need to use v5.x.x for Angular 8 support.

What's the plan to support Angular 13

PRs are welcome, but I'm not actively maintaining this project anymore.

2 fragments using the same name but from 2 different files conflicts

This is indeed because of the same IDs, which this directive doesn't try to distinguish between. It'll use whichever instance of the ID shows up first on the page (since...