arkon

Results 201 comments of arkon

I actually tried setting the button to have a tabindex of 2 and the anchor with `closesidebar` to 1. They both seem fine after opening/closing multiple times. Did you do...

@vipdorian I don't think the video's permissions are set to public.

@vipdorian Thanks, the video works now. I can reproduce it on my end too, so I'll be looking into this in the coming days.

This is actually pretty hard to reproduce consistently, but I did look over the code and made some small edits that should hopefully fix this. Feel free to reopen this...

I don't think explicitely setting a tabindex is correct either. After all, elements don't have it normally anyway.

That's intentionally done so that the elements aren't focusable when the sidebar is closed (and presumably out of the visible viewport). The current logic should already account for removing the...

Yeah, it's because it removes any tabindex value assuming that it was previously set as -1 when closing the sidebar. I can probably throw together a workaround tonight.

@k-schneider That issue should be fixed in v7.1.0.

Fork of ng-click-outside by @Kr0san89: https://www.npmjs.com/package/ng-click-outside2

This is a limitation of the library since it requires its own container for the body content to handle a lot of the more complex sidebar behaviour. Unfortunately I haven't...