ng-click-outside icon indicating copy to clipboard operation
ng-click-outside copied to clipboard

Passive

Open mdstevens044 opened this issue 5 years ago • 4 comments

Is it possible to make events passive? Running lighthouse and getting dinged for event handler not being passive.

mdstevens044 avatar May 14 '20 00:05 mdstevens044

It is possible to add. A PR would be welcomed.

arkon avatar Jul 30 '20 22:07 arkon

Okay I have only done 1 PR before so I will try and see if I can figure it out again. I believe you just have to make the addEventListener's passive.

mdstevens044 avatar Aug 07 '20 00:08 mdstevens044

Do you have a contribution guide anywhere. Never created an npm module before so not sure how to bundle it once I make changes?

mdstevens044 avatar Aug 07 '20 00:08 mdstevens044

Do you have a contribution guide anywhere.

I don't. You can refer to the scripts within package.json. You can also test it with the demo app in /demo.

arkon avatar Aug 07 '20 01:08 arkon