arkon

Results 201 comments of arkon

How can I set default arguments for all the usages across the app?

Good idea! Do you know of any other directives/components that have a similar feature to what you're looking for? I'm curious as to how something like that is typically done.

relative baseUrl path for unit tests

I imagine it's getting lost here: https://github.com/arkon/ng-inline-svg/blob/5b675dce50b62e3dbd9d73cf38826c7fb81de7e0/src/svg-cache.service.ts#L95-L98 Does that relative path actually resolve to a valid URL? (i.e. what's the absolute form of it?)

Store SVG file in localStorage, then fetch and use it using with [inLineSVG]=""

I still need to think about this but why aren't you setting the cache control on the SVG assets instead? The browser can handle that perfectly fine without any of...

Store SVG file in localStorage, then fetch and use it using with [inLineSVG]=""

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control

Any option to get the SVG without the div wrapper?

You should be able to use the `inline-svg` component IIRC.

Any option to get the SVG without the div wrapper?

Whoops sorry. I think it's still the directive, but using the `injectComponent` and `replaceContents` inputs.

Any option to get the SVG without the div wrapper?

Sorry, it's been a long time since I originally wrote this and I barely look at it nowadays. I don't think there's a way to just flat out replace your...

update angular to 13.0.0

Was this actually built and tested? I would at least expect the lock file to be updated too if so.

update angular to 13.0.0

Thanks for taking the time to contribute, but I've decided to stop maintaining this package. For more details, check out https://github.com/arkon/ng-sidebar/issues/229 If you're interested in maintaining a fork, please do...

Should support being provided with a SVG as a string

I'm not sure if it's really practical as a library user to provide data URIs. That said, I'm not entirely sure why you would readily have an SVG as a...