Yagiz Nizipli
Yagiz Nizipli
Closing in favor of https://github.com/cloudflare/workerd/pull/5965
@jasnell I believe you're right and I think it is actually faster than the current state.
@jasnell SetPrototypeProviderTemplate with RemovePrototype() is failing with a weird v8 error on debug mode. I'm investigating to see if there is a better solution here.
For reference here's the error occuring only on debug build: ``` workerd/jsg/setup.c++:38: fatal: V8 fatal error; location = external/+_repo_rules2+v8/src/api/api-natives.cc:689; message = Holder v8::internal::TrustedCast(Holder, SourceLocation) [To = v8::internal::JSObject, From = v8::internal::Object,...
Ok this a valid v8 bug. I'll open an upstream fix.
Here's the fix: https://chromium-review.googlesource.com/c/v8/v8/+/7323287
The pull-request to v8 is unlikely going to land to v8 because we have a more fundamental problem that Chromium doesn't. We have an opaque wrapper and expose our internal...
I'm taking one step back and prepare an internal document to make the best decision.
@jasnell any idea what's happening here?