Andrew Kane comments

Results 377 comments of


                                            Andrew Kane

`Marshal.dump(binding)` behavior differs from CRuby

Great, thanks!

Improve performance of copy

Hi @dvarrazzo, I created a [CI workflow](https://github.com/ankane/psycopg-repro2/blob/master/.github/workflows/build.yml) to show the difference (and can be used to test). The database is on localhost. Mac - [CI logs](https://github.com/ankane/psycopg-repro2/actions/runs/8962582762/job/24611687658) ```sh tests/scripts/copytest.py --nrecs 1000000...

Improve performance of copy

That seems reasonable. Another approach that might work for all platforms would be to keep track of the buffer size and only flush once it hits a certain threshold (so...

Improve performance of copy

Great, sounds good.

Improve performance of copy

Thanks @dvarrazzo!

Unexpected new visit creation despite continuous user activity

Hi @TheZero0-ctrl, this is the intended behavior with `Ahoy.cookies = :none`. I'll add a note to the readme about it.

Changes download to not write file before sending response

Hi @ronualdo, thanks for the suggestion and PR! I think we can switch to `send_stream` once Rails 6.1 is no longer supported ([branch](https://github.com/ankane/blazer/compare/stream-csv)).

Add `data_ptr` method to `Vips::Image`

Thanks @jcupitt. It sounds like the thread-safe way to get a read-only pointer with minimal copying is to combine the two. ```ruby copy = image.copy_memory read_ptr = copy.data_ptr ``` What...

Add `data_ptr` method to `Vips::Image`

Sounds good. Calling `ptr.slice` seems to retain the reference (otherwise, adding `GC.stress = true` to the test case should fail).

Add `data_ptr` method to `Vips::Image`

Thanks @jcupitt. Re expensive: I feel like I'm missing something about how libvips works that may make this PR not very useful. Both `write_to_memory` and `read_ptr` produce the same result....