Andrew Kane comments

Results 377 comments of


                                            Andrew Kane

set PG_SYSROOT instead of -isysroot

Thanks @tureba, the additional context I added was probably more confusing than helpful. Your PR should both fix the flags and set the SDK/sysroot to a major version.

IVFFLAT QPS too low

Hi @bantmen, if you're testing performance on a snapshot, [lazy loading](https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_RestoreFromSnapshot.html) could be the issue. > If you access data that hasn't been loaded yet, the DB instance immediately downloads...

IVFFLAT QPS too low

If lazy loading isn't the issue, just prewarming the index should be fine. I agree figuring out what's going on with I/O is a good first step.

IVFFLAT QPS too low

Cleaning up issues (don't think there's anything for pgvector to do here).

Add error codes to a few errors

Thanks @hlinnaka, makes sense to me. Going to wait until 0.8.0 to merge since it's a slightly breaking change.

Add error codes to a few errors

Starting to merge 0.8.0 work. Thanks again @hlinnaka!

`Date::Error` with `Date.parse` and JRuby 10

Tried disabling JIT and the error goes away, fwiw.

`Date::Error` with `Date.parse` and JRuby 10

Awesome, thanks @headius!

Add precision to time, datetime, and timestamp field types

Makes sense. I think it should probably always include the precision in that case.

Add default key for limits_concurrency

The test failure seems to be from a flaky test (also in [this CI run](https://github.com/rails/solid_queue/actions/runs/13512426459/job/37755039880) from February).