Andrew Kane

Results 377 comments of Andrew Kane

It looks like there are two open PRs for rb-sys for better TruffleRuby support (which probably need to be addressed before Magnus can support it). - https://github.com/oxidize-rb/rb-sys/pull/467 - https://github.com/oxidize-rb/rb-sys/pull/516

From the issues linked in the PRs, they're both needed for Magnus, which the gems mentioned in this thread use (commonmarker and polars-df). - https://github.com/oxidize-rb/rb-sys/issues/448 - https://github.com/oxidize-rb/rb-sys/issues/447

Hi @VladlenPopolitov, thanks for the PR. I added basic tests for iterative search in b26a21b848fdb0a642fa16053ebdd1baddac0e25 (as the TAP tests should cover the main functionality), but it'd be good to include...

Added minimal tests for iterative index scans with empty indexes in the commit above.

Thanks @jkatz, will merge once things are finalized.

Looks like CI is still failing for pg18, but should be okay to merge. Thanks @jkatz!

Pushed a different fix in 1291b12090bbb03bd92b92e42a1567ae5b1c96ad to address this.

Hi @lucagiac81, thanks for the PR, and sorry for the delay. Based on the numbers above, I'm not sure the benefit justifies the complexity. For the `dbpedia-openai-1000k-angular` dataset, there's a...

Sounds good. The parameter doubles my concern, but there's still a lot of complexity without it. I'm not sure either choice is great based on the numbers above, since the...

Hi @lucagiac81, thanks again for the PR, but I don't think it's a good fit for pgvector. Changing the accumulation precision can reduce recall (as @greenhal's tests show), and there...