Andrew Kane
Andrew Kane
Hi @alvaromat, what OS are you using?
Hi @VladlenPopolitov, thanks for the PR! I'm planning to focus on inline filtering after 0.7.0 (#508), so should have more thoughts then (it may take some time, so patience is...
Hi @VladlenPopolitov, thanks for sharing the benchmarks, and sorry for not getting to this sooner. I've been spending time on this area recently and think I've found an approach that...
0.8.0 is now released, so closing this out. Big thanks @VladlenPopolitov for helping move this feature forward (and finding the `TRUNCATE` crash).
Hi @eregon, I applied the following patch to numo-narray locally. ```diff --- a/ext/numo/narray/narray.c +++ b/ext/numo/narray/narray.c @@ -7,6 +7,14 @@ #include #include +#ifndef RBASIC_FLAGS +#define RBASIC_FLAGS(obj) (RBASIC(obj)->flags) +#endif + +#ifndef RBASIC_SET_FLAGS...
Thanks @eregon, will try to see why CRuby isn't throwing an error. There are other errors with the test suite with TruffleRuby as well that don't happen with CRuby. Error...
It looks like CRuby doesn't check the array length for `RARRAY_AREF`. https://github.com/ruby/ruby/blob/d0b7e5b6a04bde21ca483d20a1546b28b401c2d4/include/ruby/internal/core/rarray.h#L395-L403 Fixed with: ```diff --- a/ext/numo/narray/ndloop.c +++ b/ext/numo/narray/ndloop.c @@ -1218,6 +1218,9 @@ ndloop_extract(VALUE results, ndfunc_t *nf) case 0: return...
Error 3 ```ruby Numo::DFloat[1, 2, 3][1..] ``` ```text /Users/user/.rbenv/versions/truffleruby-24.2.0/lib/truffle/truffle/cext.rb:1315:in `rb_exc_raise': no implicit conversion from nil (TypeError) from exception.c:29:in `rb_exc_raise' from numeric.c:78:in `rb_num2ll' from /Users/user/.rbenv/versions/truffleruby-24.2.0/lib/truffle/truffle/cext.rb:1852:in `rb_ensure' from exception.c:115:in `rb_ensure' from /Users/user/.rbenv/versions/truffleruby-24.2.0/lib/truffle/truffle/cext_ruby.rb:38:in...
I think it'll be better to submit it all at once, as there isn't a lot of activity on the repo (but feel free to submit it earlier if you...
Big thanks @tureba! I believe that'll fix it. I think it'd be good to bump `SDK_PATH` to `MacOSX15.sdk` as well. (edit: this isn't really needed / can wait) To share...