ruby-lsp icon indicating copy to clipboard operation
ruby-lsp copied to clipboard
verified publisher icon Shopify

[Draft] Add jruby to CI

Open tachyons opened this issue 2 years ago • 6 comments

Add JRuby and JRuby CI to expand the platform coverage.

Motivation

Implementation

Automated Tests

Manual Tests

Fixes https://github.com/Shopify/ruby-lsp/issues/687

tachyons avatar Dec 17 '23 10:12 tachyons

Screenshot 2023-12-19 at 7 40 08 AM

This is the error I am getting, Same issue is reported by another user here

tachyons avatar Dec 19 '23 02:12 tachyons

Thank you, it seems this related to the patch we have for URI::Generic.from_path.

As Sorbet does not officially support JRuby, this may be a difficult one to solve...

andyw8 avatar Dec 19 '23 16:12 andyw8

I'm going to close this for now until we address JRuby support in https://github.com/Shopify/ruby-lsp/issues/1263. If we can find a way to support it, then we can add it to CI.

andyw8 avatar Dec 21 '23 17:12 andyw8

Re-opening this for tracking JRuby since https://github.com/Shopify/ruby-lsp/issues/1263 was resolved.

andyw8 avatar Jun 13 '24 12:06 andyw8

This pull request is being marked as stale because there was no activity in the last 2 months

github-actions[bot] avatar Aug 12 '24 12:08 github-actions[bot]

This pull request is being marked as stale because there was no activity in the last 2 months

github-actions[bot] avatar Oct 13 '24 12:10 github-actions[bot]