Andy Waite

Results 394 comments of Andy Waite

> I think GitHub is banned in China [Seems it's not](https://www.reddit.com/r/programming/comments/14yhuan/comment/jrt5npg/).

This is expected because the Rails add-on would still have its Rails process active. I'm not sure how we could solve this, as we would need to intercept that command...

> +1 this is annoying, have to force close vscode in order to drop the DB. See my comment above, you can stop Ruby LSP before running `db:drop`.

https://github.com/Shopify/ruby-lsp-rails/issues/491 will likely help this.

The callback actions are mixed in using an `included` block here: https://github.com/rails/rails/blob/fe0fb9fdf04f638996e785d3e291f5fe8bc138a0/actionpack/lib/abstract_controller/callbacks.rb#L32-L37 So https://github.com/Shopify/ruby-lsp-rails/issues/491 will likely help this.

Something isn't right with main: https://github.com/Shopify/spoom/issues/529

Can reproduce by running `spring stop` then restarting Ruby LSP.

(TODO: check if the change in https://github.com/Shopify/ruby-lsp-rails/pull/352 to run through `bundle exec` impacts this)

We haven't had any reports of this for a long time, so I will close this.

https://github.com/Shopify/ruby-lsp-rails/issues/491 will likely help this.