Andy Waite
Andy Waite
> The upgrade ended up uncovering some other Windows errors and I was trying to get CI to pass. If you prefer, I can split that into a separate PR,...
https://github.com/Shopify/ruby-lsp/pull/2033 is blocked on Windows, so I'll update this branch to remove the `/vscode` changes.
So this should also allow us to improve [Definition](https://github.com/Shopify/ruby-lsp-rails/blob/main/lib/ruby_lsp/ruby_lsp_rails/definition.rb) in ruby-lsp-rails, e.g. so that a callback method can be found even if defined in a parent controller?
This makes sense to me. Here's the relevant part of the spec: ``` * Client supports snippets as insert text. * * A snippet can define tab stops and placeholders...
@engmsaleh @batmanbury Was this on the `rails-5.1` branch? I see from the Gemfile that it's fetching some repos over `https` rather than `git` protocol, which may cause problems depending on...
I can take a look at this now that the RuboCop fix is in (since v1.38.0).
As this is now over 1 year old, I'll close it and we can return to later if needed.
I think it's better for the `return` to be a separate statement. Returning a value would suggest that it's used for something.
@mperham is this still a problem? It looks like the `config` branch has been deleted.
Ah, I see. I uncommented `debug` and is everything is passing, so can this be closed?