Shopify
Update Prism requirement to v0.28
Motivation
Update our Prism requirement to v0.28 or higher. Version v0.28 includes the new ASCIISource with performance optimization for sources that do not contain multibyte characters, which fixes the performance regression we introduced in semantic highlighting.
Implementation
- Updated Prism and RBI
- Re-generated gem RBIs
- Fixed errors related to the restructuring of constant paths
Before, each part of a constant path was also a constant read. After this version, only the parent parts of the constant path may be constant reads, the main name of the constant is embedded inside the constant path node.
# Before
# This would be 3 constant read nodes to compose the constant path
# After
# This is now 2 constant read nodes and the name `C` is a part of the overall constant path
A::B::C
Automated Tests
Fixed a few tests.
The upgrade ended up uncovering some other Windows errors and I was trying to get CI to pass. If you prefer, I can split that into a separate PR, but the changes are necessary.
The upgrade ended up uncovering some other Windows errors and I was trying to get CI to pass. If you prefer, I can split that into a separate PR, but the changes are necessary.
Ok, yeah I'd say we should split them since there's quite a lot of changes. I'll limit my review to the Ruby part.
Split the other part, which needs to be merged first https://github.com/Shopify/ruby-lsp/pull/2033.
https://github.com/Shopify/ruby-lsp/pull/2033 is blocked on Windows, so I'll update this branch to remove the /vscode changes.