Andy Waite

Results 394 comments of Andy Waite

Yes, "authenticates with OAuth successfully" would be fine. I think trying to auto-correct from the Capybara DSL to plain RSpec is going to be difficult in many cases. I wonder...

Indeed. So maybe the cop should just report the problem rather than try making any fix, e.g. `Prefer native RSpec over Capybara's acceptance test DSL ('given')` cc @backus for any...

🤔 Should this be part of a more general cop for avoiding private ActiveRecord APIs?

Good to hear. So this would require a 2.x release if following [semantic versioning](http://semver.org)?

Thanks, I will consider this.

If you could re-push it that would be great, then I can just use Github's merge button.

Ok! (I thought it was only in the GitHub description but I now see it's in the Gemfile too).

Sorry, I meant to write `.gemspec`, not `Gemfile`. But to answer your curiosity – a gem file is just a tar archive, so can be extracted: https://stackoverflow.com/questions/21824794/unpack-a-ruby-gem-without-gem-unpack-available

I believe the correct fix is just to change Rails to run `ruby bin/rubocop` instead of `bin/rubocop`.