datafusion-comet icon indicating copy to clipboard operation
datafusion-comet copied to clipboard
verified publisher icon apache

feat: Implement Spark-compatible CAST from Numeric to Binary

Open mattharder91 opened this issue 1 year ago • 2 comments

Which issue does this PR close?

https://github.com/apache/datafusion-comet/issues/405, https://github.com/apache/datafusion-comet/issues/377

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

mattharder91 avatar May 09 '24 13:05 mattharder91

I am getting

Cannot resolve "TRY_CAST(a AS BINARY)" due to data type mismatch: cannot cast "BIGINT" to "BINARY"

In non ANSI Mode and respectfully for all other INT types. It is actually the behavior from spark without comet which confuses me as I was expecting it to work or at least return null.

mattharder91 avatar May 09 '24 14:05 mattharder91 

Cannot resolve "TRY_CAST(a AS BINARY)" due to data type mismatch: cannot cast "BIGINT" to "BINARY"

Where did you get the error? Looks like BigInt to Binary is okay to cast.

viirya avatar Jul 10 '24 15:07 viirya

@mattharder91 I will close this PR for now since it has been inactive for a while. Feel free to reopen this or create a new PR if you continue work on this.

andygrove avatar Oct 22 '24 16:10 andygrove