Andrew Lock

Results 703 comments of Andrew Lock

Thanks for the clarification @ViktorHofer, this has been frustrating me more and more recently, especially as the original explanation didn't seem to justify the actual behaviour. The fact that you...

Thanks @ViktorHofer. With regard to dropping .NET Standard support - if the package throws at runtime (for significant parts of the API), then in my opinion it _doesn't_ support netstandard...

Just thought I'd flag it here @noahfalk and @ViktorHofer - [ServiceStack](https://github.com/ServiceStack/ServiceStack) recently added a dependency on DiagnosticSource v6.0 NuGet pkg on the _basis_ that it "supports" netstandard 2.0. As we've...

Cool, yep completely agree with you RE the public API!

Thanks, we're aware this is a limitation at the moment, and we're planning a long term solution to the problem of service naming across Datadog. We'll be sure to let...

## Benchmarks Report :snail: Benchmarks for #2880 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/51fb951046a308655ef36357232306dfe5304c58): * 1 benchmarks are **slower**, with geometric mean 1.181 * All benchmarks have **the same** allocations The following thresholds were...

## Code Coverage Report :bar_chart: :heavy_check_mark: Merging #2880 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/51fb951046a308655ef36357232306dfe5304c58) will **not change** line coverage :heavy_check_mark: Merging #2880 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/51fb951046a308655ef36357232306dfe5304c58) will **not change** branch coverage :heavy_check_mark: Merging #2880 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/51fb951046a308655ef36357232306dfe5304c58)...

## Benchmarks Report :snail: Benchmarks for #2880 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/2782d90d9339ad2f0f202da47632b0e82dcdf83e): * All benchmarks have **the same** speed * All benchmarks have **the same** allocations The following thresholds were used for...

## Code Coverage Report :bar_chart: :heavy_check_mark: Merging #2880 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/2782d90d9339ad2f0f202da47632b0e82dcdf83e) will **not change** line coverage :heavy_check_mark: Merging #2880 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/2782d90d9339ad2f0f202da47632b0e82dcdf83e) will **not change** branch coverage :heavy_check_mark: Merging #2880 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/2782d90d9339ad2f0f202da47632b0e82dcdf83e)...

## Benchmarks Report :snail: Benchmarks for #3051 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/ddeaf4297344edf265badd8a7c25b98876d89d09): * 1 benchmarks are **faster**, with geometric mean 1.299 * All benchmarks have **the same** allocations The following thresholds were...