Andrew Lock

Results 720 comments of Andrew Lock

Hi @kimbell, interesting, out of interest, is it a _problem_ if `self` is added twice? It's still a valid CSP I believe. _Theoretically_ making sources a `HashSet` isn't a big...

I'm torn. On the one hand, absolutely, this would reduce the number of supported frameworks. But on the other hand, it's not much of a hardship for this library, and...

🤦 Good point! > When the target framework is not NetCore 3.0 (End of line, unsupported) i.e NetStandard 2.0 Ok, but the target framework is only netstandard2.0 (and not netcore3.0)...

That page says: > ASP.NET Core 2.1 on .NET Framework Support for ASP.NET Core 2.1 on .NET Framework matches the [ASP.NET Support](https://dotnet.microsoft.com/en-us/platform/support/policy/aspnet/index) policy for other package-based ASP.NET frameworks. The complete...

Hi @alsami, is it possible to use [the `ExcludeFromCodeCoverageAttribute`](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.excludefromcodecoverageattribute?view=net-7.0) as a filter also? The latest version emits that attribute, and while the code _is_ compiler generated in a way, I'm...

Ah, my bad. FWIW, I _think_ you can work around this for now by adding the following to your app: ```csharp [CompilerGenerated] public static partial class DosingBlockStartTriggerTypeExtensions { } ```

This PR https://github.com/andrewlock/NetEscapades.EnumGenerators/pull/83 should solve the issue I think - sorry for the delay!

Yup, just working on some extra bits, then will get it out some time this week!

Hey, thanks! In principle, I'm certainly happy to support `ObjectId` 🙂 I wonder if this is the right way to handle it though 🤔 Would it be better to have...

> Hi, I thought about your opinion and you have right. I added ObjectId backing type and modified MongoSerializer to work with all backing types instead of only string and...