Move profiler CI from GitHub Actions to AzDo

[shurivich]

Summary of changes

Move profiler tests from GitActions to AzDo. Add "isNativeLoaderChanged" condition, which will force all defined exploration tests to run.

Implementation details

Following steps were transferred from GitActions to AzDo: build_linux_asan -> asan_tests_linux_profiler build_linux_ubsan -> ubsan_tests_linux_profiler build_windows_asan_release -> asan_tests_windows_profiler run_static_analysis_linux -> static_analysis_tests_linux_profiler run_static_analysis_windows -> static_analysis_tests_windows_profiler throughput_linux -> throughput_profiler throughput_windows -> throughput_profiler

Other details

The following steps still need to be moved: deploy_windows_profiler (required for reliability environment) test_windows_profiler (integration tests) benchmark_windows_x64 benchmark_linux_x64

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• 1 benchmarks are slower, with geometric mean 1.181
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	724μs	574ns	2.22μs	0	0	0	3.16 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	462μs	204ns	764ns	0	0	0	2.57 KB
#2880	WriteAndFlushEnrichedTraces	net472	728μs	197ns	763ns	0	0	0	3.16 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	503μs	177ns	685ns	0	0	0	2.57 KB

Benchmarks.Trace.AppSecBodyBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #2880

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.AppSecBodyBenchmark.BodyExtractorSimpleBody‑netcoreapp3.1	1.181	230.88	272.57

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	1.87μs	0.995ns	3.86ns	0.234	0	0	1.48 KB
master	AllCycleSimpleBody	netcoreapp3.1	1.92μs	1.8ns	6.98ns	0.0182	0	0	1.36 KB
master	AllCycleMoreComplexBody	net472	17.9μs	8.03ns	30ns	1.37	0.018	0	8.74 KB
master	AllCycleMoreComplexBody	netcoreapp3.1	14.8μs	6.37ns	24.7ns	0.104	0	0	7.84 KB
master	BodyExtractorSimpleBody	net472	261ns	0.123ns	0.46ns	0.0572	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	231ns	0.0888ns	0.332ns	0.00372	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	15.8μs	5.18ns	20.1ns	1.2	0.0157	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	13.4μs	24.6ns	91.9ns	0.0874	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	1.79μs	0.581ns	2.25ns	0.234	0	0	1.48 KB
#2880	AllCycleSimpleBody	netcoreapp3.1	1.96μs	2.25ns	8.72ns	0.0187	0	0	1.36 KB
#2880	AllCycleMoreComplexBody	net472	18.3μs	2.96ns	11.5ns	1.37	0.0183	0	8.74 KB
#2880	AllCycleMoreComplexBody	netcoreapp3.1	15.3μs	5.71ns	21.4ns	0.107	0	0	7.84 KB
#2880	BodyExtractorSimpleBody	net472	266ns	0.183ns	0.709ns	0.0571	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	273ns	0.068ns	0.254ns	0.00357	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	16.1μs	14ns	54.2ns	1.19	0.0161	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	13.3μs	3.36ns	13ns	0.0863	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	171μs	80.8ns	313ns	0.172	0	0	19.74 KB
#2880	SendRequest	net472	0.00976ns	0.00638ns	0.023ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	173μs	139ns	540ns	0.172	0	0	19.74 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.41μs	1.03ns	3.84ns	0.0941	0.000708	0	594 B
master	ExecuteNonQuery	netcoreapp3.1	1.15μs	0.865ns	3.35ns	0.00856	0	0	632 B
#2880	ExecuteNonQuery	net472	1.42μs	0.684ns	2.65ns	0.0941	0.000708	0	594 B
#2880	ExecuteNonQuery	netcoreapp3.1	1.12μs	0.501ns	1.81ns	0.00842	0	0	632 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	1.96μs	0.936ns	3.63ns	0.125	0	0	802 B
master	CallElasticsearch	netcoreapp3.1	1.26μs	0.33ns	1.23ns	0.0107	0	0	792 B
master	CallElasticsearchAsync	net472	2.19μs	0.998ns	3.73ns	0.146	0	0	939 B
master	CallElasticsearchAsync	netcoreapp3.1	1.35μs	0.34ns	1.32ns	0.0123	0	0	912 B
#2880	CallElasticsearch	net472	2.07μs	1.07ns	4.16ns	0.126	0	0	802 B
#2880	CallElasticsearch	netcoreapp3.1	1.2μs	0.605ns	2.26ns	0.0102	0	0	792 B
#2880	CallElasticsearchAsync	net472	2.25μs	1.16ns	4.2ns	0.147	0	0	939 B
#2880	CallElasticsearchAsync	netcoreapp3.1	1.36μs	0.234ns	0.845ns	0.0123	0	0	912 B

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.17μs	4.45ns	17.2ns	0.166	0	0	1.06 KB
master	ExecuteAsync	netcoreapp3.1	1.41μs	2.97ns	11.5ns	0.014	0	0	1.03 KB
#2880	ExecuteAsync	net472	2.07μs	2.88ns	10.8ns	0.166	0	0	1.06 KB
#2880	ExecuteAsync	netcoreapp3.1	1.49μs	3.15ns	12.2ns	0.0141	0	0	1.03 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	4.64μs	7.54ns	27.2ns	0.356	0	0	2.28 KB
master	SendAsync	netcoreapp3.1	3.28μs	6.18ns	23.9ns	0.0292	0	0	2.21 KB
#2880	SendAsync	net472	4.64μs	10.4ns	40.3ns	0.358	0	0	2.28 KB
#2880	SendAsync	netcoreapp3.1	3.22μs	6.78ns	26.3ns	0.0291	0	0	2.21 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.65μs	1.1ns	4.28ns	0.228	0	0	1.45 KB
master	EnrichedLog	netcoreapp3.1	2.15μs	0.568ns	2.05ns	0.0202	0	0	1.53 KB
#2880	EnrichedLog	net472	2.81μs	0.831ns	3.11ns	0.228	0	0	1.45 KB
#2880	EnrichedLog	netcoreapp3.1	2.22μs	2.58ns	10ns	0.0208	0	0	1.53 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	148μs	84.4ns	316ns	0.518	0.148	0	4.29 KB
master	EnrichedLog	netcoreapp3.1	112μs	95ns	368ns	0.056	0	0	4.18 KB
#2880	EnrichedLog	net472	147μs	111ns	431ns	0.512	0.146	0	4.29 KB
#2880	EnrichedLog	netcoreapp3.1	113μs	160ns	620ns	0	0	0	4.18 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.08μs	10.7ns	41.5ns	0.507	0.00252	0	3.23 KB
master	EnrichedLog	netcoreapp3.1	3.97μs	8.73ns	33.8ns	0.0495	0	0	3.6 KB
#2880	EnrichedLog	net472	5.13μs	6.58ns	25.5ns	0.506	0.00256	0	3.23 KB
#2880	EnrichedLog	netcoreapp3.1	4.04μs	8.6ns	33.3ns	0.0505	0	0	3.6 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	1.9μs	0.486ns	1.82ns	0.159	0	0	1.01 KB
master	SendReceive	netcoreapp3.1	1.49μs	0.549ns	2.05ns	0.0136	0	0	1.01 KB
#2880	SendReceive	net472	1.8μs	0.861ns	3.34ns	0.158	0	0	1.01 KB
#2880	SendReceive	netcoreapp3.1	1.54μs	0.702ns	2.72ns	0.0138	0	0	1.01 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.5μs	0.858ns	3.21ns	0.292	0	0	1.87 KB
master	EnrichedLog	netcoreapp3.1	3.93μs	1.75ns	6.77ns	0.0197	0	0	1.49 KB
#2880	EnrichedLog	net472	4.46μs	1.26ns	4.88ns	0.292	0	0	1.87 KB
#2880	EnrichedLog	netcoreapp3.1	4.06μs	3.38ns	13.1ns	0.0182	0	0	1.49 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	758ns	1.16ns	4.49ns	0.0718	0	0	457 B
master	StartFinishSpan	netcoreapp3.1	640ns	0.166ns	0.599ns	0.0062	0	0	456 B
master	StartFinishScope	net472	956ns	0.645ns	2.5ns	0.0845	0	0	538 B
master	StartFinishScope	netcoreapp3.1	781ns	0.243ns	0.909ns	0.00784	0	0	576 B
#2880	StartFinishSpan	net472	787ns	0.335ns	1.3ns	0.0718	0	0	457 B
#2880	StartFinishSpan	netcoreapp3.1	641ns	0.192ns	0.742ns	0.00611	0	0	456 B
#2880	StartFinishScope	net472	947ns	0.428ns	1.66ns	0.0846	0	0	538 B
#2880	StartFinishScope	netcoreapp3.1	773ns	1.21ns	4.54ns	0.00765	0	0	576 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.15μs	0.315ns	1.18ns	0.084	0	0	538 B
master	RunOnMethodBegin	netcoreapp3.1	904ns	0.224ns	0.839ns	0.00775	0	0	576 B
#2880	RunOnMethodBegin	net472	1.12μs	0.328ns	1.23ns	0.0845	0	0	538 B
#2880	RunOnMethodBegin	netcoreapp3.1	868ns	1.59ns	6.16ns	0.00753	0	0	576 B

[andrewlock]

Code Coverage Report :bar_chart:

:heavy_check_mark: Merging #2880 into master will not change line coverage :heavy_check_mark: Merging #2880 into master will not change branch coverage :heavy_check_mark: Merging #2880 into master will not change complexity

	master	#2880	Change
Lines	14751 / 20188	14733 / 20188
Lines %	73%	73%	0% :heavy_check_mark:
Branches	9037 / 12826	9029 / 12826
Branches %	70%	70%	0% :heavy_check_mark:
Complexity	13677	13677	0 :heavy_check_mark:

View the full report for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

Datadog.Trace Breakdown :heavy_check_mark:

	master	#2880	Change
Lines %	73%	73%	0% :heavy_check_mark:
Branches %	70%	70%	0% :heavy_check_mark:
Complexity	13677	13677	0 :heavy_check_mark:

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change
Datadog.Trace.Telemetry.Transports.JsonTelemetryTransport	-39% :no_entry:	-54% :no_entry:	0 :heavy_check_mark:
Datadog.Trace.Ci.GitInfo	-17% :no_entry:	-11% :no_entry:	0 :heavy_check_mark:
Datadog.Trace.Ci.CIVisibility	7% :heavy_check_mark:	7% :heavy_check_mark:	0 :heavy_check_mark:

View the full reports for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	714μs	760ns	2.94μs	0.357	0	0	3.16 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	466μs	110ns	397ns	0	0	0	2.57 KB
#2880	WriteAndFlushEnrichedTraces	net472	731μs	742ns	2.87μs	0.361	0	0	3.16 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	464μs	189ns	707ns	0	0	0	2.57 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	1.83μs	2.09ns	8.1ns	0.235	0	0	1.48 KB
master	AllCycleSimpleBody	netcoreapp3.1	2μs	3.45ns	13.4ns	0.0179	0	0	1.36 KB
master	AllCycleMoreComplexBody	net472	18μs	13.1ns	48.9ns	1.39	0.018	0	8.74 KB
master	AllCycleMoreComplexBody	netcoreapp3.1	15.8μs	20.6ns	77ns	0.102	0	0	7.84 KB
master	BodyExtractorSimpleBody	net472	278ns	0.638ns	2.47ns	0.0574	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	253ns	0.292ns	1.13ns	0.00365	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16.4μs	19.6ns	75.8ns	1.2	0.0163	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	13μs	9.91ns	34.3ns	0.0907	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	1.91μs	2.47ns	9.56ns	0.236	0	0	1.48 KB
#2880	AllCycleSimpleBody	netcoreapp3.1	1.94μs	3.39ns	13.1ns	0.0184	0	0	1.36 KB
#2880	AllCycleMoreComplexBody	net472	18.3μs	15.2ns	59ns	1.39	0.0185	0	8.74 KB
#2880	AllCycleMoreComplexBody	netcoreapp3.1	15.3μs	30.4ns	118ns	0.107	0	0	7.84 KB
#2880	BodyExtractorSimpleBody	net472	279ns	0.495ns	1.92ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	249ns	0.229ns	0.827ns	0.00375	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	16.2μs	16.3ns	63.3ns	1.21	0.0161	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	13.3μs	16.4ns	63.3ns	0.0931	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	174μs	85.8ns	332ns	0.261	0	0	19.86 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	174μs	180ns	697ns	0.261	0	0	19.86 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.55μs	0.363ns	1.36ns	0.114	0.000778	0	722 B
master	ExecuteNonQuery	netcoreapp3.1	1.28μs	1.03ns	3.84ns	0.0102	0	0	752 B
#2880	ExecuteNonQuery	net472	1.57μs	0.716ns	2.77ns	0.114	0.000778	0	722 B
#2880	ExecuteNonQuery	netcoreapp3.1	1.27μs	0.396ns	1.48ns	0.0102	0	0	752 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.27μs	0.864ns	3.35ns	0.147	0	0	931 B
master	CallElasticsearch	netcoreapp3.1	1.39μs	0.614ns	2.3ns	0.0125	0	0	912 B
master	CallElasticsearchAsync	net472	2.29μs	0.749ns	2.8ns	0.169	0	0	1.07 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.43μs	0.516ns	2ns	0.0141	0	0	1.03 KB
#2880	CallElasticsearch	net472	2.11μs	0.614ns	2.38ns	0.147	0	0	931 B
#2880	CallElasticsearch	netcoreapp3.1	1.36μs	0.874ns	3.27ns	0.0122	0	0	912 B
#2880	CallElasticsearchAsync	net472	2.27μs	0.649ns	2.43ns	0.169	0	0	1.07 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.48μs	0.906ns	3.39ns	0.0139	0	0	1.03 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.31μs	3.08ns	11.9ns	0.188	0	0	1.19 KB
master	ExecuteAsync	netcoreapp3.1	1.56μs	3.72ns	14.4ns	0.0157	0	0	1.15 KB
#2880	ExecuteAsync	net472	2.39μs	4.79ns	18.6ns	0.188	0	0	1.19 KB
#2880	ExecuteAsync	netcoreapp3.1	1.53μs	2.13ns	8.26ns	0.0154	0	0	1.15 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	4.75μs	8.25ns	32ns	0.382	0	0	2.41 KB
master	SendAsync	netcoreapp3.1	3.29μs	6.37ns	24.7ns	0.0313	0	0	2.33 KB
#2880	SendAsync	net472	4.87μs	7.52ns	28.1ns	0.38	0	0	2.41 KB
#2880	SendAsync	netcoreapp3.1	3.43μs	4.96ns	19.2ns	0.0308	0	0	2.33 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.73μs	2.64ns	10.2ns	0.251	0	0	1.58 KB
master	EnrichedLog	netcoreapp3.1	2.22μs	0.711ns	2.66ns	0.0221	0	0	1.65 KB
#2880	EnrichedLog	net472	2.76μs	1.57ns	6.08ns	0.25	0	0	1.58 KB
#2880	EnrichedLog	netcoreapp3.1	2.31μs	0.838ns	3.25ns	0.0219	0	0	1.65 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	148μs	73ns	273ns	0.674	0.225	0	4.42 KB
master	EnrichedLog	netcoreapp3.1	112μs	85.8ns	332ns	0.057	0	0	4.3 KB
#2880	EnrichedLog	net472	147μs	240ns	930ns	0.663	0.221	0	4.42 KB
#2880	EnrichedLog	netcoreapp3.1	111μs	74.4ns	288ns	0.0554	0	0	4.3 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.26μs	12.4ns	47.9ns	0.531	0.00263	0	3.35 KB
master	EnrichedLog	netcoreapp3.1	4.24μs	7.72ns	29.9ns	0.0497	0	0	3.72 KB
#2880	EnrichedLog	net472	5.34μs	11.8ns	45.5ns	0.531	0.00267	0	3.35 KB
#2880	EnrichedLog	netcoreapp3.1	4.1μs	4.43ns	17.2ns	0.0492	0	0	3.72 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	1.89μs	1.41ns	5.28ns	0.181	0	0	1.14 KB
master	SendReceive	netcoreapp3.1	1.61μs	0.448ns	1.67ns	0.0155	0	0	1.13 KB
#2880	SendReceive	net472	1.86μs	0.318ns	1.19ns	0.181	0	0	1.14 KB
#2880	SendReceive	netcoreapp3.1	1.59μs	0.473ns	1.77ns	0.0151	0	0	1.13 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.65μs	1.31ns	4.92ns	0.317	0	0	2 KB
master	EnrichedLog	netcoreapp3.1	3.99μs	1.71ns	6.15ns	0.0219	0	0	1.61 KB
#2880	EnrichedLog	net472	4.66μs	1.54ns	5.77ns	0.317	0	0	2 KB
#2880	EnrichedLog	netcoreapp3.1	4.09μs	2.3ns	8.91ns	0.0225	0	0	1.61 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	824ns	0.288ns	1.12ns	0.0928	0	0	586 B
master	StartFinishSpan	netcoreapp3.1	692ns	0.174ns	0.652ns	0.00762	0	0	576 B
master	StartFinishScope	net472	1.05μs	0.252ns	0.945ns	0.106	0	0	666 B
master	StartFinishScope	netcoreapp3.1	827ns	0.516ns	1.86ns	0.00925	0	0	696 B
#2880	StartFinishSpan	net472	831ns	0.333ns	1.29ns	0.093	0	0	586 B
#2880	StartFinishSpan	netcoreapp3.1	705ns	0.229ns	0.857ns	0.00777	0	0	576 B
#2880	StartFinishScope	net472	1.06μs	0.426ns	1.65ns	0.106	0	0	666 B
#2880	StartFinishScope	netcoreapp3.1	841ns	4.52ns	23.5ns	0.00934	0	0	696 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.3μs	0.246ns	0.888ns	0.105	0	0	666 B
master	RunOnMethodBegin	netcoreapp3.1	995ns	0.395ns	1.53ns	0.00938	0	0	696 B
#2880	RunOnMethodBegin	net472	1.22μs	0.379ns	1.42ns	0.106	0	0	666 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.02μs	0.541ns	2.02ns	0.00961	0	0	696 B

[andrewlock]

Code Coverage Report :bar_chart:

:heavy_check_mark: Merging #2880 into master will not change line coverage :heavy_check_mark: Merging #2880 into master will not change branch coverage :heavy_check_mark: Merging #2880 into master will not change complexity

	master	#2880	Change
Lines	14963 / 20437	15028 / 20437
Lines %	73%	74%	0% :heavy_check_mark:
Branches	9091 / 12924	9147 / 12924
Branches %	70%	71%	0% :heavy_check_mark:
Complexity	13793	13793	0 :heavy_check_mark:

View the full report for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

Datadog.Trace Breakdown :heavy_check_mark:

	master	#2880	Change
Lines %	73%	74%	0% :heavy_check_mark:
Branches %	70%	71%	0% :heavy_check_mark:
Complexity	13793	13793	0 :heavy_check_mark:

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change
Datadog.Trace.ExtensionMethods.SpanExtensions	4% :heavy_check_mark:	7% :heavy_check_mark:	0 :heavy_check_mark:
Datadog.Trace.Ci.CIVisibility	7% :heavy_check_mark:	7% :heavy_check_mark:	0 :heavy_check_mark:
Datadog.Trace.Propagators.SpanContextPropagator	8% :heavy_check_mark:	6% :heavy_check_mark:	0 :heavy_check_mark:
Datadog.Trace.Telemetry.Transports.JsonTelemetryTransport	39% :heavy_check_mark:	54% :heavy_check_mark:	0 :heavy_check_mark:

View the full reports for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

[datadog-ddstaging[bot]]

Datadog Report

All test runs 87fbd70 :link:

:white_check_mark: 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Wall Time	Branch View
dd-trace-dotnet (ci)	0	0	0	226802	1113	18m 46.63s	Link
dd-trace-dotnet (none)	0	0	0	8	0	6m 30.13s	Link

[datadog-ddstaging[bot]]

Datadog Report

Branch report: shurivich/profiler_ci Commit report: 1b8f3f8

:white_check_mark: dd-trace-dotnet 0 Failed, 0 New Flaky, 4 Passed, 0 Skipped, 32.81s Wall Time

[datadog-ddstaging[bot]]

Datadog Report

Branch report: shurivich/profiler_ci Commit report: b89d636

:white_check_mark: dd-trace-dotnet 0 Failed, 0 New Flaky, 4 Passed, 0 Skipped, 31.61s Wall Time

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	773μs	727ns	2.52μs	0.377	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	559μs	260ns	1.01μs	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	752μs	642ns	2.49μs	0.377	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	550μs	245ns	915ns	0	0	0	2.62 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	185ns	0.0772ns	0.278ns	0.0675	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	242ns	0.329ns	1.28ns	0.0058	0	0	424 B
master	AllCycleMoreComplexBody	net472	183ns	0.132ns	0.51ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	236ns	0.0729ns	0.273ns	0.00551	0	0	400 B
master	BodyExtractorSimpleBody	net472	290ns	0.134ns	0.482ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	248ns	0.106ns	0.41ns	0.00364	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	15.9μs	15.2ns	58.8ns	1.2	0.0157	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	36ns	139ns	0.0876	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	183ns	0.0865ns	0.324ns	0.0675	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	241ns	0.135ns	0.504ns	0.00568	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	180ns	0.0336ns	0.126ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	242ns	0.129ns	0.5ns	0.0055	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	303ns	0.546ns	2.04ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	257ns	0.397ns	1.54ns	0.00367	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	15.8μs	7.56ns	26.2ns	1.2	0.0159	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.6μs	4.69ns	18.2ns	0.0883	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	175μs	100ns	375ns	0.262	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	174μs	175ns	679ns	0.261	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.82μs	0.66ns	2.56ns	0.16	0.000909	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.34μs	0.649ns	2.51ns	0.0134	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.74μs	0.561ns	2.1ns	0.16	0.000864	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.43μs	0.703ns	2.72ns	0.0136	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.5μs	0.724ns	2.71ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.49μs	2.23ns	9.72ns	0.0155	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.65μs	0.89ns	3.33ns	0.215	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.61μs	0.92ns	3.44ns	0.0169	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.45μs	1.26ns	4.87ns	0.193	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.49μs	0.309ns	1.16ns	0.0157	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.62μs	2.91ns	11.3ns	0.214	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.61μs	0.364ns	1.36ns	0.017	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.71μs	1.3ns	5.05ns	0.235	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.76μs	0.62ns	2.32ns	0.0194	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.71μs	0.889ns	3.33ns	0.236	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.79μs	0.69ns	2.49ns	0.0189	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.85μs	1.58ns	5.91ns	0.449	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.56μs	2.26ns	8.44ns	0.0356	0	0	2.66 KB
#2880	SendAsync	net472	5.73μs	1.53ns	5.73ns	0.448	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.66μs	2.08ns	8.07ns	0.0348	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.81μs	3.01ns	11.7ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.42μs	1.17ns	4.37ns	0.0263	0	0	1.91 KB
#2880	EnrichedLog	net472	2.88μs	2.36ns	8.51ns	0.298	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.32μs	1.09ns	4.24ns	0.0265	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	151μs	84.1ns	315ns	0.679	0.226	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	120μs	150ns	582ns	0.0599	0	0	4.55 KB
#2880	EnrichedLog	net472	150μs	86.8ns	336ns	0.749	0.225	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	121μs	132ns	496ns	0.0603	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.46μs	1.74ns	6.29ns	0.579	0.00274	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.4μs	2.97ns	11.1ns	0.0525	0	0	3.98 KB
#2880	EnrichedLog	net472	5.31μs	1.59ns	6.17ns	0.578	0.00265	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.19μs	1.43ns	5.34ns	0.0526	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.18μs	10.7ns	46.8ns	0.227	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.85μs	0.393ns	1.47ns	0.0186	0	0	1.38 KB
#2880	SendReceive	net472	2.28μs	1.43ns	5.53ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.86μs	0.881ns	3.3ns	0.0187	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.06μs	2.29ns	8.85ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	3.89μs	0.986ns	3.69ns	0.0253	0	0	1.86 KB
#2880	EnrichedLog	net472	4.73μs	1.54ns	5.76ns	0.363	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	3.84μs	1.99ns	7.44ns	0.0249	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.13μs	0.267ns	0.998ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	935ns	0.362ns	1.35ns	0.0112	0	0	824 B
master	StartFinishScope	net472	1.36μs	0.442ns	1.71ns	0.152	0	0	955 B
master	StartFinishScope	netcoreapp3.1	990ns	0.364ns	1.36ns	0.0129	0	0	944 B
#2880	StartFinishSpan	net472	1.16μs	0.596ns	2.31ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	905ns	0.291ns	1.13ns	0.0113	0	0	824 B
#2880	StartFinishScope	net472	1.34μs	0.34ns	1.32ns	0.152	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.04μs	0.407ns	1.52ns	0.0128	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.5μs	0.483ns	1.87ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.11μs	0.44ns	1.7ns	0.0127	0	0	944 B
#2880	RunOnMethodBegin	net472	1.39μs	0.489ns	1.76ns	0.152	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.2μs	0.394ns	1.47ns	0.0128	0	0	944 B

[andrewlock]

Code Coverage Report :bar_chart:

:heavy_check_mark: Merging #2880 into master will not change line coverage :heavy_check_mark: Merging #2880 into master will not change branch coverage :heavy_check_mark: Merging #2880 into master will not change complexity

	master	#2880	Change
Lines	19942 / 27203	19887 / 27203
Lines %	73%	73%	0% :heavy_check_mark:
Branches	11485 / 16607	11463 / 16607
Branches %	69%	69%	0% :heavy_check_mark:
Complexity	18026	18026	0 :heavy_check_mark:

View the full report for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

Datadog.Trace Breakdown :heavy_check_mark:

	master	#2880	Change
Lines %	73%	73%	0% :heavy_check_mark:
Branches %	69%	69%	0% :heavy_check_mark:
Complexity	18026	18026	0 :heavy_check_mark:

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change
Datadog.Trace.Ci.GitInfo	-17% :no_entry:	-10% :no_entry:	0 :heavy_check_mark:

View the full reports for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	777μs	537ns	2.08μs	0.386	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	545μs	208ns	806ns	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	780μs	326ns	1.26μs	0.386	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	556μs	193ns	720ns	0	0	0	2.63 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	182ns	0.105ns	0.38ns	0.0676	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	240ns	0.159ns	0.594ns	0.00572	0	0	424 B
master	AllCycleMoreComplexBody	net472	180ns	0.0612ns	0.229ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.0826ns	0.32ns	0.00546	0	0	400 B
master	BodyExtractorSimpleBody	net472	309ns	0.252ns	0.976ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	237ns	0.191ns	0.716ns	0.00368	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16.1μs	18ns	69.6ns	1.2	0.0159	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	5.57ns	21.6ns	0.0882	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	190ns	0.0955ns	0.357ns	0.0675	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	243ns	0.19ns	0.737ns	0.00576	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	182ns	0.0538ns	0.201ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	241ns	0.275ns	1.06ns	0.00543	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	306ns	0.356ns	1.38ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	238ns	0.365ns	1.42ns	0.00365	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	16.1μs	15ns	56.1ns	1.21	0.0161	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	13μs	6.18ns	23.1ns	0.0909	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	176μs	154ns	598ns	0.261	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	175μs	136ns	528ns	0.263	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.76μs	0.404ns	1.51ns	0.161	0.000892	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.43μs	0.62ns	2.32ns	0.0136	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.77μs	0.572ns	2.22ns	0.16	0.000884	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.44μs	0.712ns	2.66ns	0.013	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.48μs	12.7ns	61.1ns	0.194	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.55μs	0.62ns	2.4ns	0.0158	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.56μs	1.55ns	5.82ns	0.215	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.6μs	0.572ns	2.14ns	0.0176	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.46μs	0.859ns	3.33ns	0.193	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.52μs	0.5ns	1.8ns	0.016	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.54μs	0.724ns	2.61ns	0.215	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.52μs	0.346ns	1.25ns	0.0175	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.69μs	1.2ns	4.51ns	0.235	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.72μs	1.13ns	4.39ns	0.0189	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.72μs	1.13ns	4.37ns	0.235	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.75μs	1.06ns	4.12ns	0.0192	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.77μs	1.55ns	6ns	0.449	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.76μs	2.29ns	8.88ns	0.0357	0	0	2.66 KB
#2880	SendAsync	net472	5.79μs	8.85ns	31.9ns	0.449	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.68μs	1.4ns	5.25ns	0.0353	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.82μs	1.11ns	4.29ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.3μs	1.74ns	6.5ns	0.0253	0	0	1.91 KB
#2880	EnrichedLog	net472	2.84μs	0.894ns	3.46ns	0.298	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.36μs	2ns	7.49ns	0.0257	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	151μs	107ns	415ns	0.677	0.226	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	120μs	168ns	652ns	0.0617	0	0	4.55 KB
#2880	EnrichedLog	net472	151μs	84.6ns	316ns	0.677	0.226	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	119μs	177ns	685ns	0.0592	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.43μs	2.84ns	10.6ns	0.579	0.00272	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.22μs	1.33ns	4.96ns	0.0527	0	0	3.98 KB
#2880	EnrichedLog	net472	5.79μs	1.64ns	6.12ns	0.578	0.00277	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.3μs	1.97ns	7.62ns	0.0534	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.13μs	1.46ns	5.26ns	0.228	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.83μs	0.697ns	2.61ns	0.0183	0	0	1.38 KB
#2880	SendReceive	net472	2.21μs	0.717ns	2.68ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.79μs	0.487ns	1.75ns	0.0188	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.68μs	1.28ns	4.79ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	3.99μs	1.77ns	6.62ns	0.0238	0	0	1.86 KB
#2880	EnrichedLog	net472	4.74μs	3.7ns	13.9ns	0.364	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	3.98μs	1.2ns	4.31ns	0.0247	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.19μs	0.442ns	1.59ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	943ns	0.564ns	2.19ns	0.0113	0	0	824 B
master	StartFinishScope	net472	1.28μs	0.332ns	1.29ns	0.151	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.05μs	0.337ns	1.3ns	0.0127	0	0	944 B
#2880	StartFinishSpan	net472	1.14μs	0.219ns	0.789ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	894ns	0.492ns	1.91ns	0.0112	0	0	824 B
#2880	StartFinishScope	net472	1.34μs	0.483ns	1.81ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.14μs	0.235ns	0.91ns	0.0124	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.46μs	0.395ns	1.42ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.15μs	0.41ns	1.59ns	0.0127	0	0	944 B
#2880	RunOnMethodBegin	net472	1.43μs	0.513ns	1.99ns	0.151	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.14μs	0.638ns	2.47ns	0.0125	0	0	944 B

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	777μs	537ns	2.08μs	0.386	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	545μs	208ns	806ns	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	772μs	328ns	1.23μs	0.383	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	568μs	222ns	859ns	0	0	0	2.62 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	182ns	0.105ns	0.38ns	0.0676	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	240ns	0.159ns	0.594ns	0.00572	0	0	424 B
master	AllCycleMoreComplexBody	net472	180ns	0.0612ns	0.229ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.0826ns	0.32ns	0.00546	0	0	400 B
master	BodyExtractorSimpleBody	net472	309ns	0.252ns	0.976ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	237ns	0.191ns	0.716ns	0.00368	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16.1μs	18ns	69.6ns	1.2	0.0159	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	5.57ns	21.6ns	0.0882	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	184ns	0.126ns	0.487ns	0.0676	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	239ns	0.0815ns	0.294ns	0.00567	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	182ns	0.0942ns	0.34ns	0.0638	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	238ns	0.262ns	1.02ns	0.00539	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	304ns	0.193ns	0.697ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	245ns	0.287ns	1.11ns	0.00368	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	15.7μs	11.7ns	45.3ns	1.21	0.0158	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.6μs	6.37ns	23ns	0.0881	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	176μs	154ns	598ns	0.261	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	175μs	156ns	605ns	0.261	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.76μs	0.404ns	1.51ns	0.161	0.000892	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.43μs	0.62ns	2.32ns	0.0136	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.81μs	0.433ns	1.68ns	0.16	0.000904	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.44μs	0.397ns	1.48ns	0.0138	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.48μs	12.7ns	61.1ns	0.194	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.55μs	0.62ns	2.4ns	0.0158	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.56μs	1.55ns	5.82ns	0.215	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.6μs	0.572ns	2.14ns	0.0176	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.57μs	0.83ns	3.1ns	0.193	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.5μs	1.27ns	4.91ns	0.0158	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.58μs	1.07ns	3.99ns	0.215	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.63μs	1.05ns	3.78ns	0.0169	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.69μs	1.2ns	4.51ns	0.235	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.72μs	1.13ns	4.39ns	0.0189	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.71μs	1.36ns	5.28ns	0.236	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.71μs	0.704ns	2.44ns	0.0188	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.77μs	1.55ns	6ns	0.449	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.76μs	2.29ns	8.88ns	0.0357	0	0	2.66 KB
#2880	SendAsync	net472	5.69μs	1.75ns	6.54ns	0.448	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.6μs	1.19ns	4.47ns	0.036	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.82μs	1.11ns	4.29ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.3μs	1.74ns	6.5ns	0.0253	0	0	1.91 KB
#2880	EnrichedLog	net472	2.78μs	4.04ns	14.6ns	0.298	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.2μs	0.54ns	1.95ns	0.0263	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	151μs	107ns	415ns	0.677	0.226	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	120μs	168ns	652ns	0.0617	0	0	4.55 KB
#2880	EnrichedLog	net472	150μs	204ns	762ns	0.748	0.224	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	121μs	90.8ns	352ns	0.0599	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.43μs	2.84ns	10.6ns	0.579	0.00272	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.22μs	1.33ns	4.96ns	0.0527	0	0	3.98 KB
#2880	EnrichedLog	net472	5.54μs	2.22ns	8.29ns	0.578	0.00278	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.39μs	2.24ns	8.38ns	0.0523	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.13μs	1.46ns	5.26ns	0.228	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.83μs	0.697ns	2.61ns	0.0183	0	0	1.38 KB
#2880	SendReceive	net472	2.09μs	1.44ns	5.39ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.77μs	0.932ns	3.49ns	0.0185	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.68μs	1.28ns	4.79ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	3.99μs	1.77ns	6.62ns	0.0238	0	0	1.86 KB
#2880	EnrichedLog	net472	4.7μs	1.76ns	6.83ns	0.365	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	4.05μs	1.65ns	6.41ns	0.0244	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.19μs	0.442ns	1.59ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	943ns	0.564ns	2.19ns	0.0113	0	0	824 B
master	StartFinishScope	net472	1.28μs	0.332ns	1.29ns	0.151	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.05μs	0.337ns	1.3ns	0.0127	0	0	944 B
#2880	StartFinishSpan	net472	1.16μs	0.363ns	1.41ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	905ns	0.263ns	1.02ns	0.0112	0	0	824 B
#2880	StartFinishScope	net472	1.37μs	0.759ns	2.94ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.01μs	0.26ns	1.01ns	0.0132	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.46μs	0.395ns	1.42ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.15μs	0.41ns	1.59ns	0.0127	0	0	944 B
#2880	RunOnMethodBegin	net472	1.45μs	0.606ns	2.35ns	0.152	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.12μs	0.19ns	0.712ns	0.0127	0	0	944 B

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	772μs	541ns	2.1μs	0.381	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	553μs	92.1ns	344ns	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	780μs	576ns	2.23μs	0.386	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	555μs	485ns	1.88μs	0	0	0	2.62 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	183ns	0.116ns	0.435ns	0.0675	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	243ns	0.176ns	0.683ns	0.00581	0	0	424 B
master	AllCycleMoreComplexBody	net472	181ns	0.16ns	0.6ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	238ns	0.183ns	0.71ns	0.00548	0	0	400 B
master	BodyExtractorSimpleBody	net472	287ns	0.314ns	1.09ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	239ns	0.148ns	0.553ns	0.0036	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	15.9μs	18.8ns	72.9ns	1.2	0.0158	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.5μs	9.18ns	35.6ns	0.0868	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	182ns	0.152ns	0.57ns	0.0675	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	240ns	0.195ns	0.754ns	0.00576	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	181ns	0.112ns	0.42ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	238ns	0.196ns	0.759ns	0.00545	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	301ns	0.134ns	0.503ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	265ns	0.211ns	0.789ns	0.00371	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	16.3μs	18.6ns	69.4ns	1.21	0.0163	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.8μs	10.7ns	40ns	0.0894	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	174μs	182ns	706ns	0.263	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	176μs	131ns	489ns	0.183	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.78μs	0.517ns	2ns	0.16	0.000891	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.44μs	0.544ns	1.96ns	0.0137	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.82μs	0.769ns	2.98ns	0.16	0.000914	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.43μs	0.731ns	2.83ns	0.0136	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.36μs	1.63ns	6.3ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.59μs	0.705ns	2.64ns	0.0159	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.64μs	2.05ns	7.93ns	0.215	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.62μs	0.423ns	1.58ns	0.017	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.5μs	0.763ns	2.85ns	0.194	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.53μs	1.51ns	5.43ns	0.0161	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.53μs	0.902ns	3.38ns	0.215	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.66μs	0.273ns	1.06ns	0.0175	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.66μs	0.681ns	2.64ns	0.236	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.76μs	0.556ns	2.01ns	0.0193	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.56μs	0.87ns	3.25ns	0.236	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.65μs	0.408ns	1.47ns	0.0191	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.77μs	1.38ns	5.36ns	0.447	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.73μs	2.31ns	8.65ns	0.0355	0	0	2.66 KB
#2880	SendAsync	net472	5.83μs	1.8ns	6.98ns	0.449	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.68μs	1.32ns	4.74ns	0.0371	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.87μs	0.931ns	3.36ns	0.297	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.22μs	1.45ns	5.61ns	0.0256	0	0	1.91 KB
#2880	EnrichedLog	net472	2.74μs	7.15ns	27.7ns	0.297	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.28μs	1.02ns	3.66ns	0.0262	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	149μs	161ns	622ns	0.747	0.224	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	121μs	342ns	1.32μs	0.0599	0	0	4.55 KB
#2880	EnrichedLog	net472	150μs	74.5ns	279ns	0.749	0.225	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	120μs	152ns	569ns	0.0599	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.48μs	3.44ns	13.3ns	0.578	0.00274	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.39μs	1.97ns	7.38ns	0.054	0	0	3.98 KB
#2880	EnrichedLog	net472	5.34μs	1.18ns	4.59ns	0.578	0.00269	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.26μs	2.09ns	8.1ns	0.0528	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.1μs	0.734ns	2.75ns	0.228	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.78μs	0.708ns	2.65ns	0.0187	0	0	1.38 KB
#2880	SendReceive	net472	2.17μs	2.69ns	10ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.83μs	0.472ns	1.7ns	0.0192	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.71μs	1.16ns	4.5ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	4.09μs	1.14ns	3.96ns	0.0242	0	0	1.86 KB
#2880	EnrichedLog	net472	4.71μs	1.97ns	7.37ns	0.364	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	3.94μs	1.31ns	4.92ns	0.0236	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.2μs	0.698ns	2.7ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	955ns	0.27ns	1.04ns	0.011	0	0	824 B
master	StartFinishScope	net472	1.37μs	0.281ns	1.01ns	0.151	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.07μs	0.631ns	2.36ns	0.0128	0	0	944 B
#2880	StartFinishSpan	net472	1.2μs	0.506ns	1.89ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	927ns	0.19ns	0.712ns	0.0112	0	0	824 B
#2880	StartFinishScope	net472	1.39μs	0.994ns	3.85ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.09μs	0.348ns	1.3ns	0.0127	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.45μs	0.333ns	1.29ns	0.152	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.21μs	0.239ns	0.896ns	0.0127	0	0	944 B
#2880	RunOnMethodBegin	net472	1.39μs	0.575ns	2.23ns	0.152	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.16μs	0.333ns	1.25ns	0.0127	0	0	944 B

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• 1 benchmarks are slower, with geometric mean 1.148
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	768μs	358ns	1.34μs	0.381	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	551μs	390ns	1.51μs	0	0	0	2.62 KB
#2880	WriteAndFlushEnrichedTraces	net472	768μs	421ns	1.63μs	0.386	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	553μs	183ns	661ns	0	0	0	2.63 KB

Benchmarks.Trace.AppSecBodyBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #2880

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.AppSecBodyBenchmark.BodyExtractorSimpleBody‑net472	1.148	277.02	318.00

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	189ns	0.0715ns	0.258ns	0.0675	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	239ns	0.118ns	0.442ns	0.00585	0	0	424 B
master	AllCycleMoreComplexBody	net472	181ns	0.16ns	0.621ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	238ns	0.154ns	0.577ns	0.00549	0	0	400 B
master	BodyExtractorSimpleBody	net472	277ns	0.407ns	1.52ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	239ns	0.222ns	0.83ns	0.00367	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16μs	17.9ns	69.5ns	1.21	0.016	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	5.25ns	18.9ns	0.0886	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	186ns	0.0434ns	0.162ns	0.0675	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	238ns	0.224ns	0.869ns	0.00586	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	188ns	0.121ns	0.468ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.205ns	0.794ns	0.00556	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	318ns	0.659ns	2.47ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	244ns	0.0961ns	0.36ns	0.0037	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	16.3μs	10.1ns	39.3ns	1.2	0.0162	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	4.35ns	16.8ns	0.0887	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	176μs	184ns	714ns	0.261	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	175μs	115ns	447ns	0.261	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.77μs	0.689ns	2.67ns	0.161	0.000883	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.42μs	0.32ns	1.2ns	0.0134	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.83μs	0.523ns	1.96ns	0.16	0.000901	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.4μs	0.474ns	1.77ns	0.0133	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.47μs	1.06ns	4.12ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.49μs	0.776ns	2.9ns	0.0158	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.75μs	1.64ns	5.91ns	0.215	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.56μs	0.677ns	2.53ns	0.0172	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.57μs	0.864ns	3.35ns	0.193	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.53μs	1.29ns	4.66ns	0.0154	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.67μs	1.82ns	6.79ns	0.216	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.62μs	1.16ns	4.49ns	0.0177	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.68μs	0.959ns	3.71ns	0.236	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.79μs	0.684ns	2.47ns	0.0188	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.67μs	0.722ns	2.7ns	0.236	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.66μs	0.414ns	1.6ns	0.0193	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.81μs	2.47ns	9.23ns	0.45	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.71μs	5.77ns	21.6ns	0.0368	0	0	2.66 KB
#2880	SendAsync	net472	5.87μs	1.62ns	6.28ns	0.449	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.59μs	1.76ns	6.57ns	0.0361	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.72μs	3.06ns	11.4ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.27μs	1.24ns	4.47ns	0.0263	0	0	1.91 KB
#2880	EnrichedLog	net472	2.79μs	1.7ns	6.14ns	0.297	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.35μs	1.33ns	5.16ns	0.0259	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	151μs	239ns	926ns	0.745	0.223	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	120μs	159ns	618ns	0.0598	0	0	4.55 KB
#2880	EnrichedLog	net472	150μs	45.3ns	170ns	0.749	0.225	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	120μs	141ns	545ns	0.0598	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.17μs	1.22ns	4.4ns	0.579	0.0026	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.27μs	3.68ns	14.2ns	0.053	0	0	3.98 KB
#2880	EnrichedLog	net472	5.42μs	1.55ns	5.99ns	0.578	0.00272	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.25μs	1.33ns	4.78ns	0.053	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.19μs	2.62ns	9.43ns	0.227	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.74μs	0.555ns	2.15ns	0.0192	0	0	1.38 KB
#2880	SendReceive	net472	2.29μs	1.42ns	5.51ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.82μs	0.885ns	3.43ns	0.0191	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.78μs	1.72ns	6.66ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	3.91μs	1.07ns	4.15ns	0.0236	0	0	1.86 KB
#2880	EnrichedLog	net472	4.75μs	2.31ns	8.93ns	0.364	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	4.02μs	1.49ns	5.79ns	0.0241	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.18μs	0.235ns	0.911ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	912ns	0.17ns	0.636ns	0.0114	0	0	824 B
master	StartFinishScope	net472	1.32μs	0.802ns	3.1ns	0.151	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.06μs	0.212ns	0.793ns	0.0127	0	0	944 B
#2880	StartFinishSpan	net472	1.13μs	0.985ns	3.68ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	918ns	0.263ns	1.02ns	0.011	0	0	824 B
#2880	StartFinishScope	net472	1.39μs	0.896ns	3.47ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.02μs	0.362ns	1.35ns	0.0128	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.4μs	0.238ns	0.923ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.17μs	1.36ns	5.25ns	0.0128	0	0	944 B
#2880	RunOnMethodBegin	net472	1.34μs	0.578ns	2.24ns	0.151	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.16μs	0.419ns	1.57ns	0.0127	0	0	944 B

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	773μs	263ns	984ns	0.391	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	566μs	544ns	2.11μs	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	776μs	454ns	1.76μs	0.386	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	537μs	166ns	621ns	0	0	0	2.63 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	183ns	0.107ns	0.415ns	0.0676	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	239ns	0.0914ns	0.329ns	0.0058	0	0	424 B
master	AllCycleMoreComplexBody	net472	182ns	0.0721ns	0.26ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.0814ns	0.305ns	0.00563	0	0	400 B
master	BodyExtractorSimpleBody	net472	283ns	0.216ns	0.837ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	238ns	0.0599ns	0.216ns	0.00374	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16.1μs	9.91ns	37.1ns	1.21	0.0162	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.5μs	8.08ns	30.2ns	0.0936	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	183ns	0.0413ns	0.149ns	0.0676	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	241ns	0.23ns	0.89ns	0.00592	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	181ns	0.0927ns	0.359ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.181ns	0.702ns	0.00558	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	292ns	0.261ns	0.975ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	245ns	0.112ns	0.433ns	0.0037	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	15.9μs	14.9ns	57.7ns	1.21	0.0159	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	5.39ns	20.2ns	0.0887	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	175μs	144ns	558ns	0.261	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	174μs	119ns	444ns	0.26	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.76μs	0.637ns	2.38ns	0.16	0.00088	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.43μs	1.02ns	3.81ns	0.0135	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.84μs	0.787ns	3.05ns	0.16	0.000915	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.45μs	0.489ns	1.89ns	0.0138	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.49μs	0.821ns	2.96ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.48μs	0.486ns	1.82ns	0.0157	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.61μs	0.707ns	2.74ns	0.215	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.65μs	0.542ns	2.03ns	0.0173	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.54μs	0.753ns	2.82ns	0.193	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.53μs	0.943ns	3.4ns	0.0153	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.69μs	0.956ns	3.58ns	0.215	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.64μs	0.559ns	2.17ns	0.0172	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.83μs	1.16ns	4.51ns	0.236	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.73μs	0.314ns	1.13ns	0.0191	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.69μs	0.988ns	3.7ns	0.236	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.75μs	0.697ns	2.61ns	0.0185	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.8μs	1.75ns	6.78ns	0.447	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.64μs	0.73ns	2.53ns	0.0348	0	0	2.66 KB
#2880	SendAsync	net472	5.84μs	2.21ns	8.58ns	0.45	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.57μs	2.99ns	11.2ns	0.0358	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.8μs	1.24ns	4.65ns	0.297	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.29μs	0.425ns	1.53ns	0.0252	0	0	1.91 KB
#2880	EnrichedLog	net472	2.77μs	4.16ns	15.6ns	0.297	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.4μs	1.21ns	4.54ns	0.0252	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	150μs	116ns	434ns	0.748	0.224	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	119μs	137ns	529ns	0	0	0	4.55 KB
#2880	EnrichedLog	net472	153μs	268ns	1.04μs	0.686	0.229	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	121μs	116ns	435ns	0.0602	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.49μs	1.55ns	6.02ns	0.58	0.00275	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.34μs	1.51ns	5.66ns	0.0542	0	0	3.98 KB
#2880	EnrichedLog	net472	5.44μs	2.02ns	7.29ns	0.579	0.00269	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.23μs	1.1ns	4.28ns	0.0529	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.23μs	1.39ns	5.39ns	0.228	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.74μs	0.543ns	1.96ns	0.0192	0	0	1.38 KB
#2880	SendReceive	net472	2.25μs	2.37ns	9.16ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.7μs	1.04ns	3.88ns	0.0188	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.71μs	2.43ns	9.41ns	0.364	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	4.1μs	0.62ns	2.15ns	0.0247	0	0	1.86 KB
#2880	EnrichedLog	net472	4.84μs	1.44ns	5.4ns	0.363	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	4.11μs	1.63ns	6.1ns	0.0247	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.15μs	0.242ns	0.837ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	881ns	0.205ns	0.765ns	0.0114	0	0	824 B
master	StartFinishScope	net472	1.32μs	0.972ns	3.77ns	0.151	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.03μs	0.514ns	1.99ns	0.0129	0	0	944 B
#2880	StartFinishSpan	net472	1.19μs	0.427ns	1.65ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	948ns	0.376ns	1.41ns	0.0109	0	0	824 B
#2880	StartFinishScope	net472	1.34μs	0.733ns	2.84ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.03μs	0.417ns	1.62ns	0.0128	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.44μs	0.362ns	1.4ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.17μs	0.624ns	2.34ns	0.0129	0	0	944 B
#2880	RunOnMethodBegin	net472	1.41μs	0.388ns	1.5ns	0.151	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.16μs	0.46ns	1.78ns	0.0127	0	0	944 B

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	775μs	505ns	1.96μs	0.388	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	544μs	126ns	486ns	0	0	0	2.62 KB
#2880	WriteAndFlushEnrichedTraces	net472	774μs	480ns	1.86μs	0.386	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	549μs	103ns	357ns	0	0	0	2.62 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	187ns	0.0359ns	0.134ns	0.0675	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	238ns	0.161ns	0.622ns	0.00587	0	0	424 B
master	AllCycleMoreComplexBody	net472	181ns	0.114ns	0.443ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	236ns	0.131ns	0.507ns	0.00553	0	0	400 B
master	BodyExtractorSimpleBody	net472	282ns	0.247ns	0.924ns	0.0574	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	242ns	0.195ns	0.757ns	0.00379	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16μs	12.5ns	48.3ns	1.21	0.0158	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.4μs	4.31ns	16.7ns	0.0928	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	187ns	0.0507ns	0.176ns	0.0676	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	240ns	0.285ns	1.1ns	0.00588	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	181ns	0.142ns	0.55ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	236ns	0.0697ns	0.251ns	0.00544	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	275ns	0.441ns	1.71ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	244ns	0.776ns	2.8ns	0.00377	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	16.1μs	12.7ns	49.4ns	1.21	0.0161	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.9μs	7.66ns	28.7ns	0.0899	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	173μs	116ns	448ns	0.26	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	176μs	197ns	737ns	0.175	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.83μs	0.93ns	3.6ns	0.16	0.000909	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.39μs	0.989ns	3.7ns	0.0132	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.77μs	0.629ns	2.44ns	0.16	0.000885	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.39μs	2.16ns	8.37ns	0.0135	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.33μs	1.12ns	4.33ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.5μs	0.393ns	1.52ns	0.0159	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.58μs	1.15ns	4.47ns	0.215	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.56μs	0.537ns	2.01ns	0.0178	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.56μs	0.97ns	3.76ns	0.193	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.53μs	5.8ns	22.5ns	0.0159	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.55μs	0.694ns	2.6ns	0.214	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.62μs	0.564ns	2.11ns	0.0169	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.78μs	2.39ns	8.92ns	0.236	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.7μs	0.764ns	2.96ns	0.0188	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.71μs	1.3ns	5.04ns	0.235	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.75μs	1.1ns	4.28ns	0.0192	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.73μs	1.25ns	4.83ns	0.449	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.68μs	0.965ns	3.74ns	0.0349	0	0	2.66 KB
#2880	SendAsync	net472	5.84μs	2.14ns	8.02ns	0.447	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.59μs	1.82ns	6.8ns	0.0359	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.76μs	1.56ns	6.06ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.27μs	0.97ns	3.63ns	0.0251	0	0	1.91 KB
#2880	EnrichedLog	net472	2.8μs	2.26ns	8.76ns	0.297	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.25μs	1.77ns	6.86ns	0.0256	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	151μs	102ns	394ns	0.679	0.226	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	118μs	328ns	1.27μs	0.0589	0	0	4.55 KB
#2880	EnrichedLog	net472	150μs	73.9ns	286ns	0.676	0.225	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	120μs	105ns	393ns	0.06	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.56μs	1.83ns	7.09ns	0.579	0.00278	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.39μs	1.41ns	5.26ns	0.0549	0	0	3.98 KB
#2880	EnrichedLog	net472	5.53μs	1.74ns	6.53ns	0.578	0.00276	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.25μs	2.43ns	9.08ns	0.0531	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.22μs	2.52ns	9.76ns	0.228	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.75μs	0.666ns	2.31ns	0.0192	0	0	1.38 KB
#2880	SendReceive	net472	2.21μs	2.28ns	8.54ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.77μs	1.08ns	3.89ns	0.0186	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.83μs	1.64ns	6.14ns	0.364	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	4.14μs	1.45ns	5.43ns	0.0247	0	0	1.86 KB
#2880	EnrichedLog	net472	4.71μs	2.13ns	8.26ns	0.363	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	3.98μs	1.1ns	4.11ns	0.0255	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.2μs	0.459ns	1.78ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	944ns	0.265ns	0.991ns	0.0108	0	0	824 B
master	StartFinishScope	net472	1.38μs	0.674ns	2.52ns	0.151	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.08μs	0.3ns	1.12ns	0.0124	0	0	944 B
#2880	StartFinishSpan	net472	1.11μs	0.348ns	1.3ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	926ns	0.432ns	1.56ns	0.0111	0	0	824 B
#2880	StartFinishScope	net472	1.39μs	0.24ns	0.865ns	0.152	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.11μs	0.406ns	1.52ns	0.0127	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.39μs	0.337ns	1.3ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.14μs	0.307ns	1.15ns	0.0125	0	0	944 B
#2880	RunOnMethodBegin	net472	1.49μs	0.475ns	1.84ns	0.152	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.13μs	0.439ns	1.7ns	0.0131	0	0	944 B

[datadog-ddstaging[bot]]

Datadog Report

Branch report: shurivich/profiler_ci Commit report: 790c943

:white_check_mark: dd-trace-dotnet 0 Failed, 0 New Flaky, 224569 Passed, 671 Skipped, 19m 42.01s Wall Time

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	756μs	583ns	2.26μs	0.381	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	551μs	561ns	2.17μs	0	0	0	2.62 KB
#2880	WriteAndFlushEnrichedTraces	net472	759μs	354ns	1.37μs	0.377	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	550μs	176ns	658ns	0	0	0	2.62 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	181ns	0.0282ns	0.102ns	0.0675	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	241ns	0.217ns	0.84ns	0.00583	0	0	424 B
master	AllCycleMoreComplexBody	net472	180ns	0.1ns	0.388ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	238ns	0.231ns	0.894ns	0.00551	0	0	400 B
master	BodyExtractorSimpleBody	net472	278ns	0.199ns	0.745ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	257ns	0.13ns	0.486ns	0.00375	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	15.9μs	14.4ns	55.9ns	1.21	0.0162	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.6μs	6.47ns	24.2ns	0.0941	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	182ns	0.0975ns	0.351ns	0.0676	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	240ns	0.218ns	0.814ns	0.00579	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	181ns	0.0327ns	0.113ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	239ns	0.224ns	0.866ns	0.0055	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	291ns	0.213ns	0.799ns	0.0574	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	250ns	0.13ns	0.485ns	0.00364	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	16.1μs	16.7ns	64.6ns	1.21	0.016	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.9μs	7.69ns	28.8ns	0.0898	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	177μs	192ns	717ns	0.264	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	177μs	260ns	1.01μs	0.263	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.8μs	1.08ns	4.18ns	0.16	0.000898	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.36μs	0.617ns	2.31ns	0.013	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.72μs	0.898ns	3.36ns	0.16	0.00086	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.41μs	0.843ns	3.04ns	0.0135	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.42μs	0.744ns	2.88ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.5μs	0.876ns	3.39ns	0.0157	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.65μs	1.37ns	5.32ns	0.215	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.58μs	0.971ns	3.63ns	0.0174	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.4μs	0.88ns	3.41ns	0.194	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.52μs	1.11ns	4.17ns	0.0153	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.71μs	0.773ns	2.99ns	0.215	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.59μs	0.564ns	2.11ns	0.0168	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.64μs	1ns	3.76ns	0.235	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.73μs	1.63ns	6.33ns	0.019	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.74μs	0.674ns	2.52ns	0.236	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.73μs	0.744ns	2.68ns	0.0191	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.81μs	1.51ns	5.65ns	0.447	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.62μs	1.51ns	5.86ns	0.036	0	0	2.66 KB
#2880	SendAsync	net472	5.9μs	1.68ns	6.52ns	0.449	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.69μs	1.68ns	6.3ns	0.0349	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.84μs	1.23ns	4.75ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.38μs	1.03ns	3.85ns	0.026	0	0	1.91 KB
#2880	EnrichedLog	net472	2.9μs	0.746ns	2.69ns	0.298	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.25μs	1.09ns	4.07ns	0.026	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	149μs	82.2ns	307ns	0.748	0.224	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	119μs	98.3ns	368ns	0.0591	0	0	4.55 KB
#2880	EnrichedLog	net472	147μs	71.5ns	277ns	0.734	0.22	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	119μs	71ns	266ns	0.06	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.6μs	3.03ns	11.3ns	0.578	0.00281	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.22μs	2.05ns	7.95ns	0.0546	0	0	3.98 KB
#2880	EnrichedLog	net472	5.39μs	1.36ns	5.1ns	0.579	0.00268	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.35μs	1.49ns	5.56ns	0.0524	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.2μs	1.67ns	6.48ns	0.228	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.77μs	0.692ns	2.59ns	0.0182	0	0	1.38 KB
#2880	SendReceive	net472	2.13μs	1.09ns	4.24ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.84μs	0.594ns	2.06ns	0.0185	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.87μs	2.87ns	11.1ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	4.1μs	1.84ns	7.13ns	0.0246	0	0	1.86 KB
#2880	EnrichedLog	net472	4.74μs	2.12ns	8.19ns	0.365	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	4.01μs	2.08ns	7.78ns	0.024	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.1μs	0.438ns	1.7ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	909ns	1.27ns	4.76ns	0.0113	0	0	824 B
master	StartFinishScope	net472	1.32μs	0.499ns	1.93ns	0.152	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.06μs	1.05ns	3.94ns	0.0128	0	0	944 B
#2880	StartFinishSpan	net472	1.18μs	0.323ns	1.21ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	902ns	0.289ns	1.04ns	0.0112	0	0	824 B
#2880	StartFinishScope	net472	1.38μs	0.349ns	1.35ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.05μs	0.492ns	1.84ns	0.0131	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.5μs	0.403ns	1.51ns	0.152	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.16μs	0.447ns	1.73ns	0.0129	0	0	944 B
#2880	RunOnMethodBegin	net472	1.48μs	0.493ns	1.84ns	0.151	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.1μs	0.348ns	1.25ns	0.0126	0	0	944 B

[andrewlock]

Code Coverage Report :bar_chart:

:heavy_check_mark: Merging #2880 into master will not change line coverage :heavy_check_mark: Merging #2880 into master will not change branch coverage :heavy_check_mark: Merging #2880 into master will not change complexity

	master	#2880	Change
Lines	20196 / 28332	20093 / 28332
Lines %	71%	71%	0% :heavy_check_mark:
Branches	12050 / 18047	11998 / 18047
Branches %	67%	66%	0% :heavy_check_mark:
Complexity	19491	19491	0 :heavy_check_mark:

View the full report for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

Datadog.Trace Breakdown :heavy_check_mark:

	master	#2880	Change
Lines %	71%	71%	0% :heavy_check_mark:
Branches %	67%	66%	0% :heavy_check_mark:
Complexity	19491	19491	0 :heavy_check_mark:

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change
Datadog.Trace.Ci.GitInfo	-22% :no_entry:	-20% :no_entry:	0 :heavy_check_mark:

View the full reports for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	751μs	550ns	2.13μs	0.386	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	546μs	200ns	776ns	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	754μs	446ns	1.67μs	0.377	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	555μs	186ns	696ns	0	0	0	2.63 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	182ns	0.0966ns	0.348ns	0.0676	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	240ns	0.363ns	1.41ns	0.00579	0	0	424 B
master	AllCycleMoreComplexBody	net472	182ns	0.0763ns	0.275ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.338ns	1.31ns	0.00548	0	0	400 B
master	BodyExtractorSimpleBody	net472	279ns	0.225ns	0.841ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	243ns	0.0905ns	0.326ns	0.00368	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16.1μs	18.6ns	72.2ns	1.21	0.016	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	4.63ns	17.3ns	0.0889	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	183ns	0.204ns	0.79ns	0.0675	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	239ns	0.28ns	1.09ns	0.00575	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	181ns	0.173ns	0.622ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.238ns	0.92ns	0.00547	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	312ns	1.61ns	7.72ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	242ns	0.159ns	0.616ns	0.00367	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	15.9μs	10.9ns	40.6ns	1.2	0.0158	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.4μs	6.74ns	25.2ns	0.0872	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	175μs	92.5ns	358ns	0.261	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	176μs	147ns	568ns	0.262	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.86μs	0.872ns	3.38ns	0.161	0.000907	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.31μs	0.544ns	2.11ns	0.0133	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.79μs	2.36ns	8.84ns	0.161	0.000887	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.36μs	0.52ns	2.01ns	0.0135	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.42μs	1ns	3.88ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.5μs	0.897ns	3.47ns	0.0158	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.65μs	0.888ns	3.32ns	0.214	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.59μs	0.407ns	1.52ns	0.0174	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.48μs	0.97ns	3.5ns	0.194	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.48μs	0.446ns	1.61ns	0.0156	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.59μs	1.36ns	5.25ns	0.215	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.59μs	0.471ns	1.76ns	0.0175	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.74μs	0.995ns	3.72ns	0.235	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.7μs	0.724ns	2.8ns	0.0188	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.65μs	0.852ns	3.19ns	0.236	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.64μs	1.14ns	4.1ns	0.0196	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.77μs	2.16ns	8.37ns	0.447	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.69μs	1.05ns	3.93ns	0.0351	0	0	2.66 KB
#2880	SendAsync	net472	5.89μs	2.32ns	8.98ns	0.45	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.68μs	3.93ns	15.2ns	0.035	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.86μs	1.51ns	5.85ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.31μs	2.92ns	11.3ns	0.0261	0	0	1.91 KB
#2880	EnrichedLog	net472	2.79μs	3.06ns	11.8ns	0.297	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.33μs	1.16ns	4.49ns	0.0266	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	153μs	373ns	1.45μs	0.678	0.226	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	119μs	95.4ns	357ns	0.0596	0	0	4.55 KB
#2880	EnrichedLog	net472	150μs	64.5ns	250ns	0.749	0.225	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	119μs	198ns	741ns	0	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.5μs	1.6ns	6.19ns	0.579	0.00274	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.3μs	4.38ns	16.9ns	0.0538	0	0	3.98 KB
#2880	EnrichedLog	net472	5.5μs	2.41ns	9ns	0.579	0.00276	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.2μs	1.62ns	5.83ns	0.0548	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.2μs	3.35ns	12.5ns	0.227	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.83μs	1.11ns	4.3ns	0.0183	0	0	1.38 KB
#2880	SendReceive	net472	2.24μs	2.16ns	8.36ns	0.227	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.74μs	0.912ns	3.41ns	0.0183	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.75μs	1.22ns	4.71ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	3.95μs	2.73ns	10.2ns	0.0237	0	0	1.86 KB
#2880	EnrichedLog	net472	4.73μs	2.2ns	8.51ns	0.364	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	4.12μs	1.38ns	5.15ns	0.0244	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.17μs	0.278ns	1ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	913ns	3.39ns	13.1ns	0.0113	0	0	824 B
master	StartFinishScope	net472	1.34μs	0.521ns	1.95ns	0.152	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.04μs	0.419ns	1.57ns	0.0125	0	0	944 B
#2880	StartFinishSpan	net472	1.13μs	0.227ns	0.878ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	935ns	0.405ns	1.46ns	0.0112	0	0	824 B
#2880	StartFinishScope	net472	1.28μs	0.502ns	1.88ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.04μs	0.303ns	1.13ns	0.0125	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.45μs	0.391ns	1.46ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.14μs	0.243ns	0.877ns	0.0127	0	0	944 B
#2880	RunOnMethodBegin	net472	1.43μs	0.355ns	1.37ns	0.152	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.16μs	0.369ns	1.38ns	0.0128	0	0	944 B

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	751μs	550ns	2.13μs	0.386	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	546μs	200ns	776ns	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	756μs	243ns	878ns	0.379	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	554μs	265ns	990ns	0	0	0	2.62 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	182ns	0.0966ns	0.348ns	0.0676	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	240ns	0.363ns	1.41ns	0.00579	0	0	424 B
master	AllCycleMoreComplexBody	net472	182ns	0.0763ns	0.275ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.338ns	1.31ns	0.00548	0	0	400 B
master	BodyExtractorSimpleBody	net472	279ns	0.225ns	0.841ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	243ns	0.0905ns	0.326ns	0.00368	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16.1μs	18.6ns	72.2ns	1.21	0.016	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	4.63ns	17.3ns	0.0889	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	182ns	0.0738ns	0.266ns	0.0676	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	238ns	0.243ns	0.943ns	0.00588	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	181ns	0.0458ns	0.171ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.199ns	0.744ns	0.00548	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	295ns	0.213ns	0.797ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	252ns	0.131ns	0.509ns	0.00366	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	16μs	16.3ns	61.1ns	1.21	0.016	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.8μs	7.19ns	26.9ns	0.0902	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	175μs	92.5ns	358ns	0.261	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	175μs	155ns	598ns	0.261	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.86μs	0.872ns	3.38ns	0.161	0.000907	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.31μs	0.544ns	2.11ns	0.0133	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.83μs	0.728ns	2.82ns	0.161	0.000918	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.4μs	0.89ns	3.33ns	0.014	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.42μs	1ns	3.88ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.5μs	0.897ns	3.47ns	0.0158	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.65μs	0.888ns	3.32ns	0.214	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.59μs	0.407ns	1.52ns	0.0174	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.53μs	2.42ns	9.04ns	0.193	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.52μs	0.591ns	2.21ns	0.0153	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.62μs	2.5ns	9.36ns	0.214	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.62μs	0.446ns	1.54ns	0.0169	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.74μs	0.995ns	3.72ns	0.235	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.7μs	0.724ns	2.8ns	0.0188	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.77μs	1.27ns	4.58ns	0.235	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.67μs	0.424ns	1.53ns	0.0193	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.77μs	2.16ns	8.37ns	0.447	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.69μs	1.05ns	3.93ns	0.0351	0	0	2.66 KB
#2880	SendAsync	net472	5.81μs	2.21ns	8.56ns	0.448	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.59μs	0.861ns	3.1ns	0.0357	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.86μs	1.51ns	5.85ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.31μs	2.92ns	11.3ns	0.0261	0	0	1.91 KB
#2880	EnrichedLog	net472	2.99μs	3.87ns	15ns	0.298	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.39μs	1.9ns	7.37ns	0.0263	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	153μs	373ns	1.45μs	0.678	0.226	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	119μs	95.4ns	357ns	0.0596	0	0	4.55 KB
#2880	EnrichedLog	net472	151μs	217ns	841ns	0.677	0.226	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	120μs	114ns	425ns	0.0603	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.5μs	1.6ns	6.19ns	0.579	0.00274	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.3μs	4.38ns	16.9ns	0.0538	0	0	3.98 KB
#2880	EnrichedLog	net472	5.48μs	2.03ns	7.88ns	0.579	0.00274	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.33μs	1.21ns	4.67ns	0.0541	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.2μs	3.35ns	12.5ns	0.227	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.83μs	1.11ns	4.3ns	0.0183	0	0	1.38 KB
#2880	SendReceive	net472	2.29μs	3.4ns	13.2ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.79μs	5.98ns	23.2ns	0.0186	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.75μs	1.22ns	4.71ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	3.95μs	2.73ns	10.2ns	0.0237	0	0	1.86 KB
#2880	EnrichedLog	net472	4.64μs	2.17ns	8.13ns	0.363	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	4.08μs	1.32ns	4.93ns	0.0243	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.17μs	0.278ns	1ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	913ns	3.39ns	13.1ns	0.0113	0	0	824 B
master	StartFinishScope	net472	1.34μs	0.521ns	1.95ns	0.152	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.04μs	0.419ns	1.57ns	0.0125	0	0	944 B
#2880	StartFinishSpan	net472	1.12μs	0.444ns	1.72ns	0.138	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	887ns	0.72ns	2.59ns	0.0114	0	0	824 B
#2880	StartFinishScope	net472	1.41μs	0.755ns	2.82ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.01μs	0.689ns	2.58ns	0.0127	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.45μs	0.391ns	1.46ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.14μs	0.243ns	0.877ns	0.0127	0	0	944 B
#2880	RunOnMethodBegin	net472	1.45μs	0.462ns	1.73ns	0.151	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.25μs	0.377ns	1.41ns	0.0125	0	0	944 B

[andrewlock]

Code Coverage Report :bar_chart:

:heavy_check_mark: Merging #2880 into master will not change line coverage :heavy_check_mark: Merging #2880 into master will not change branch coverage :heavy_check_mark: Merging #2880 into master will not change complexity

	master	#2880	Change
Lines	20196 / 28332	20171 / 28332
Lines %	71%	71%	0% :heavy_check_mark:
Branches	12050 / 18047	12023 / 18047
Branches %	67%	67%	0% :heavy_check_mark:
Complexity	19491	19491	0 :heavy_check_mark:

View the full report for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

Datadog.Trace Breakdown :heavy_check_mark:

	master	#2880	Change
Lines %	71%	71%	0% :heavy_check_mark:
Branches %	67%	67%	0% :heavy_check_mark:
Complexity	19491	19491	0 :heavy_check_mark:

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change
Datadog.Trace.Ci.GitInfo	7% :heavy_check_mark:	-1% :warning:	0 :heavy_check_mark:

View the full reports for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	751μs	550ns	2.13μs	0.386	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	546μs	200ns	776ns	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	746μs	500ns	1.87μs	0.37	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	551μs	480ns	1.86μs	0	0	0	2.63 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	182ns	0.0966ns	0.348ns	0.0676	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	240ns	0.363ns	1.41ns	0.00579	0	0	424 B
master	AllCycleMoreComplexBody	net472	182ns	0.0763ns	0.275ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.338ns	1.31ns	0.00548	0	0	400 B
master	BodyExtractorSimpleBody	net472	279ns	0.225ns	0.841ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	243ns	0.0905ns	0.326ns	0.00368	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16.1μs	18.6ns	72.2ns	1.21	0.016	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	4.63ns	17.3ns	0.0889	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	184ns	0.0864ns	0.312ns	0.0675	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	239ns	0.197ns	0.762ns	0.00571	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	182ns	0.139ns	0.52ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.177ns	0.684ns	0.00545	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	292ns	0.446ns	1.67ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	247ns	0.0981ns	0.38ns	0.00362	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	15.8μs	16.8ns	62.7ns	1.21	0.0157	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.5μs	5.03ns	18.8ns	0.0877	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	175μs	92.5ns	358ns	0.261	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	174μs	128ns	496ns	0.261	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.86μs	0.872ns	3.38ns	0.161	0.000907	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.31μs	0.544ns	2.11ns	0.0133	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.86μs	0.826ns	3.09ns	0.16	0.00093	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.4μs	0.481ns	1.73ns	0.0134	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.42μs	1ns	3.88ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.5μs	0.897ns	3.47ns	0.0158	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.65μs	0.888ns	3.32ns	0.214	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.59μs	0.407ns	1.52ns	0.0174	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.45μs	1.39ns	5.4ns	0.194	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.53μs	0.827ns	3.2ns	0.0162	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.65μs	0.81ns	3.03ns	0.215	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.5μs	0.532ns	1.99ns	0.0173	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.74μs	0.995ns	3.72ns	0.235	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.7μs	0.724ns	2.8ns	0.0188	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.74μs	1.45ns	5.63ns	0.235	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.74μs	0.48ns	1.73ns	0.0192	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.77μs	2.16ns	8.37ns	0.447	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.69μs	1.05ns	3.93ns	0.0351	0	0	2.66 KB
#2880	SendAsync	net472	5.91μs	1.26ns	4.72ns	0.449	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.71μs	1.15ns	4.29ns	0.0349	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.86μs	1.51ns	5.85ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.31μs	2.92ns	11.3ns	0.0261	0	0	1.91 KB
#2880	EnrichedLog	net472	2.89μs	4.45ns	17.2ns	0.298	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.25μs	1.12ns	4.18ns	0.0258	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	153μs	373ns	1.45μs	0.678	0.226	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	119μs	95.4ns	357ns	0.0596	0	0	4.55 KB
#2880	EnrichedLog	net472	151μs	180ns	673ns	0.679	0.226	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	121μs	134ns	518ns	0.06	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.5μs	1.6ns	6.19ns	0.579	0.00274	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.3μs	4.38ns	16.9ns	0.0538	0	0	3.98 KB
#2880	EnrichedLog	net472	5.43μs	1.42ns	5.51ns	0.579	0.0027	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.33μs	1.52ns	5.69ns	0.0541	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.2μs	3.35ns	12.5ns	0.227	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.83μs	1.11ns	4.3ns	0.0183	0	0	1.38 KB
#2880	SendReceive	net472	2.23μs	3.26ns	12.6ns	0.227	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.77μs	0.655ns	2.45ns	0.0187	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.75μs	1.22ns	4.71ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	3.95μs	2.73ns	10.2ns	0.0237	0	0	1.86 KB
#2880	EnrichedLog	net472	4.83μs	1.95ns	7.28ns	0.364	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	4.17μs	2.07ns	7.73ns	0.025	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.17μs	0.278ns	1ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	913ns	3.39ns	13.1ns	0.0113	0	0	824 B
master	StartFinishScope	net472	1.34μs	0.521ns	1.95ns	0.152	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.04μs	0.419ns	1.57ns	0.0125	0	0	944 B
#2880	StartFinishSpan	net472	1.18μs	1.23ns	4.75ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	895ns	0.246ns	0.919ns	0.0112	0	0	824 B
#2880	StartFinishScope	net472	1.33μs	0.543ns	2.03ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.1μs	1.33ns	4.98ns	0.013	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.45μs	0.391ns	1.46ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.14μs	0.243ns	0.877ns	0.0127	0	0	944 B
#2880	RunOnMethodBegin	net472	1.45μs	0.693ns	2.69ns	0.151	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.12μs	0.323ns	1.21ns	0.0129	0	0	944 B

[andrewlock]

Code Coverage Report :bar_chart:

:heavy_check_mark: Merging #2880 into master will not change line coverage :heavy_check_mark: Merging #2880 into master will not change branch coverage :heavy_check_mark: Merging #2880 into master will not change complexity

	master	#2880	Change
Lines	20196 / 28332	20210 / 28332
Lines %	71%	71%	0% :heavy_check_mark:
Branches	12050 / 18047	12054 / 18047
Branches %	67%	67%	0% :heavy_check_mark:
Complexity	19491	19491	0 :heavy_check_mark:

View the full report for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

Datadog.Trace Breakdown :heavy_check_mark:

	master	#2880	Change
Lines %	71%	71%	0% :heavy_check_mark:
Branches %	67%	67%	0% :heavy_check_mark:
Complexity	19491	19491	0 :heavy_check_mark:

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change

View the full reports for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• All benchmarks have the same speed
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	751μs	550ns	2.13μs	0.386	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	546μs	200ns	776ns	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	761μs	612ns	2.21μs	0.379	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	547μs	145ns	523ns	0	0	0	2.63 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	182ns	0.0966ns	0.348ns	0.0676	0	0	425 B
master	AllCycleSimpleBody	netcoreapp3.1	240ns	0.363ns	1.41ns	0.00579	0	0	424 B
master	AllCycleMoreComplexBody	net472	182ns	0.0763ns	0.275ns	0.0637	0	0	401 B
master	AllCycleMoreComplexBody	netcoreapp3.1	237ns	0.338ns	1.31ns	0.00548	0	0	400 B
master	BodyExtractorSimpleBody	net472	279ns	0.225ns	0.841ns	0.0573	0	0	361 B
master	BodyExtractorSimpleBody	netcoreapp3.1	243ns	0.0905ns	0.326ns	0.00368	0	0	272 B
master	BodyExtractorMoreComplexBody	net472	16.1μs	18.6ns	72.2ns	1.21	0.016	0	7.62 KB
master	BodyExtractorMoreComplexBody	netcoreapp3.1	12.7μs	4.63ns	17.3ns	0.0889	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	182ns	0.0501ns	0.187ns	0.0675	0	0	425 B
#2880	AllCycleSimpleBody	netcoreapp3.1	239ns	0.161ns	0.601ns	0.00579	0	0	424 B
#2880	AllCycleMoreComplexBody	net472	181ns	0.0857ns	0.309ns	0.0637	0	0	401 B
#2880	AllCycleMoreComplexBody	netcoreapp3.1	240ns	0.16ns	0.6ns	0.00558	0	0	400 B
#2880	BodyExtractorSimpleBody	net472	282ns	0.194ns	0.751ns	0.0573	0	0	361 B
#2880	BodyExtractorSimpleBody	netcoreapp3.1	255ns	0.0836ns	0.313ns	0.00372	0	0	272 B
#2880	BodyExtractorMoreComplexBody	net472	15.9μs	15.5ns	59.9ns	1.2	0.0158	0	7.62 KB
#2880	BodyExtractorMoreComplexBody	netcoreapp3.1	12.5μs	7.61ns	28.5ns	0.0932	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	175μs	92.5ns	358ns	0.261	0	0	20.44 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	177μs	196ns	758ns	0.265	0	0	20.44 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.86μs	0.872ns	3.38ns	0.161	0.000907	0	1.01 KB
master	ExecuteNonQuery	netcoreapp3.1	1.31μs	0.544ns	2.11ns	0.0133	0	0	1 KB
#2880	ExecuteNonQuery	net472	1.75μs	0.716ns	2.68ns	0.161	0.000872	0	1.01 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.35μs	0.371ns	1.39ns	0.0135	0	0	1 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.42μs	1ns	3.88ns	0.193	0	0	1.22 KB
master	CallElasticsearch	netcoreapp3.1	1.5μs	0.897ns	3.47ns	0.0158	0	0	1.16 KB
master	CallElasticsearchAsync	net472	2.65μs	0.888ns	3.32ns	0.214	0	0	1.36 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.59μs	0.407ns	1.52ns	0.0174	0	0	1.28 KB
#2880	CallElasticsearch	net472	2.57μs	0.748ns	2.7ns	0.193	0	0	1.22 KB
#2880	CallElasticsearch	netcoreapp3.1	1.55μs	3.56ns	13.8ns	0.0153	0	0	1.16 KB
#2880	CallElasticsearchAsync	net472	2.59μs	0.923ns	3.57ns	0.215	0	0	1.36 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.51μs	0.936ns	3.62ns	0.0174	0	0	1.28 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.74μs	0.995ns	3.72ns	0.235	0	0	1.49 KB
master	ExecuteAsync	netcoreapp3.1	1.7μs	0.724ns	2.8ns	0.0188	0	0	1.41 KB
#2880	ExecuteAsync	net472	2.79μs	1.58ns	6.12ns	0.236	0	0	1.49 KB
#2880	ExecuteAsync	netcoreapp3.1	1.72μs	2.29ns	8.86ns	0.0187	0	0	1.41 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	5.77μs	2.16ns	8.37ns	0.447	0	0	2.83 KB
master	SendAsync	netcoreapp3.1	3.69μs	1.05ns	3.93ns	0.0351	0	0	2.66 KB
#2880	SendAsync	net472	5.85μs	2.82ns	10.9ns	0.45	0	0	2.83 KB
#2880	SendAsync	netcoreapp3.1	3.67μs	2.05ns	7.67ns	0.0366	0	0	2.66 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.86μs	1.51ns	5.85ns	0.298	0	0	1.88 KB
master	EnrichedLog	netcoreapp3.1	2.31μs	2.92ns	11.3ns	0.0261	0	0	1.91 KB
#2880	EnrichedLog	net472	2.8μs	3.3ns	12.4ns	0.298	0	0	1.88 KB
#2880	EnrichedLog	netcoreapp3.1	2.2μs	0.932ns	3.49ns	0.0254	0	0	1.91 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	153μs	373ns	1.45μs	0.678	0.226	0	4.72 KB
master	EnrichedLog	netcoreapp3.1	119μs	95.4ns	357ns	0.0596	0	0	4.55 KB
#2880	EnrichedLog	net472	150μs	101ns	392ns	0.678	0.226	0	4.72 KB
#2880	EnrichedLog	netcoreapp3.1	120μs	115ns	446ns	0	0	0	4.55 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.5μs	1.6ns	6.19ns	0.579	0.00274	0	3.65 KB
master	EnrichedLog	netcoreapp3.1	4.3μs	4.38ns	16.9ns	0.0538	0	0	3.98 KB
#2880	EnrichedLog	net472	5.52μs	2.01ns	7.25ns	0.58	0.00275	0	3.65 KB
#2880	EnrichedLog	netcoreapp3.1	4.33μs	2ns	6.92ns	0.0527	0	0	3.98 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.2μs	3.35ns	12.5ns	0.227	0	0	1.44 KB
master	SendReceive	netcoreapp3.1	1.83μs	1.11ns	4.3ns	0.0183	0	0	1.38 KB
#2880	SendReceive	net472	2.22μs	2.4ns	9.31ns	0.228	0	0	1.44 KB
#2880	SendReceive	netcoreapp3.1	1.82μs	0.845ns	2.93ns	0.0191	0	0	1.38 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.75μs	1.22ns	4.71ns	0.363	0	0	2.3 KB
master	EnrichedLog	netcoreapp3.1	3.95μs	2.73ns	10.2ns	0.0237	0	0	1.86 KB
#2880	EnrichedLog	net472	4.82μs	2.37ns	9.16ns	0.363	0	0	2.3 KB
#2880	EnrichedLog	netcoreapp3.1	3.92μs	8.06ns	30.1ns	0.0253	0	0	1.86 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.17μs	0.278ns	1ns	0.139	0	0	875 B
master	StartFinishSpan	netcoreapp3.1	913ns	3.39ns	13.1ns	0.0113	0	0	824 B
master	StartFinishScope	net472	1.34μs	0.521ns	1.95ns	0.152	0	0	955 B
master	StartFinishScope	netcoreapp3.1	1.04μs	0.419ns	1.57ns	0.0125	0	0	944 B
#2880	StartFinishSpan	net472	1.19μs	0.572ns	2.14ns	0.139	0	0	875 B
#2880	StartFinishSpan	netcoreapp3.1	902ns	0.241ns	0.836ns	0.0111	0	0	824 B
#2880	StartFinishScope	net472	1.35μs	0.593ns	2.3ns	0.151	0	0	955 B
#2880	StartFinishScope	netcoreapp3.1	1.09μs	0.355ns	1.38ns	0.013	0	0	944 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.45μs	0.391ns	1.46ns	0.151	0	0	955 B
master	RunOnMethodBegin	netcoreapp3.1	1.14μs	0.243ns	0.877ns	0.0127	0	0	944 B
#2880	RunOnMethodBegin	net472	1.46μs	0.878ns	3.4ns	0.152	0	0	955 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.14μs	1.38ns	5.36ns	0.0128	0	0	944 B

[andrewlock]

Code Coverage Report :bar_chart:

:heavy_check_mark: Merging #2880 into master will not change line coverage :heavy_check_mark: Merging #2880 into master will not change branch coverage :heavy_check_mark: Merging #2880 into master will not change complexity

	master	#2880	Change
Lines	20196 / 28332	20155 / 28332
Lines %	71%	71%	0% :heavy_check_mark:
Branches	12050 / 18047	12018 / 18047
Branches %	67%	67%	0% :heavy_check_mark:
Complexity	19491	19491	0 :heavy_check_mark:

View the full report for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

Datadog.Trace Breakdown :heavy_check_mark:

	master	#2880	Change
Lines %	71%	71%	0% :heavy_check_mark:
Branches %	67%	67%	0% :heavy_check_mark:
Complexity	19491	19491	0 :heavy_check_mark:

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change

View the full reports for further details:

• HTML report for master | Source file
• HTML report for this PR #2880 | Source file

[datadog-ddstaging[bot]]

Datadog Report

Branch report: shurivich/profiler_ci Commit report: 6016cdd

:x: dd-trace-dotnet 14 Failed (0 Known Flaky), 0 New Flaky, 228116 Passed, 683 Skipped, 19m 17.62s Wall Time

:x: Failed Tests (14)

This report shows up to 5 failed tests.

• MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMinimalApisTestsCallTargetWithFeatureFlag - Details

  Expand for error

  Test Class Cleanup Failure (Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMinimalApisTestsCallTargetWithFeatureFlag)]: System.Net.WebException : Cannot assign requested address [::1]:36609 (localhost:36609)
  --- System.Net.Http.HttpRequestException : Cannot assign requested address [::1]:36609 (localhost:36609)
  ------- System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Cannot assign requested address [::1]:36609
  

• MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMinimalApisTestsCallTargetWithFeatureFlag - Details

  Expand for error

  Test Class Cleanup Failure (Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMinimalApisTestsCallTargetWithFeatureFlag)]: System.Net.WebException : Cannot assign requested address [::1]:36609 (localhost:36609)
  --- System.Net.Http.HttpRequestException : Cannot assign requested address [::1]:36609 (localhost:36609)
  ------- System.Net.Internals.SocketExceptionFactory+ExtendedSocketException : Cannot assign requested address [::1]:36609
  

• MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMinimalApisTestsCallTargetWithFeatureFlag - Details

  Expand for error

  annot assign requested address (localhost:36609)
  --- System.Net.Sockets.SocketException : Cannot assign requested address
  

• MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMinimalApisTestsCallTargetWithFeatureFlag - Details

  Expand for error

  annot assign requested address (localhost:36609)
  --- System.Net.Sockets.SocketException : Cannot assign requested address
  

• MeetsAllAspNetCoreMvcExpectations - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore.AspNetCoreMinimalApisTestsCallTargetWithFeatureFlag - Details

  Expand for error

  annot assign requested address (localhost:36609)
  --- System.Net.Sockets.SocketException : Cannot assign requested address
  

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• 1 benchmarks are slower, with geometric mean 1.145
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	764μs	386ns	1.39μs	0.379	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	569μs	625ns	2.42μs	0	0	0	2.62 KB
#2880	WriteAndFlushEnrichedTraces	net472	774μs	739ns	2.77μs	0.386	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	579μs	649ns	2.51μs	0	0	0	2.62 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	24.6μs	130ns	714ns	0.281	0	0	1.78 KB
master	AllCycleSimpleBody	netcoreapp3.1	21.1μs	8.13ns	53.3ns	0.0121	0	0	1.65 KB
master	AllCycleMoreComplexBody	net472	191μs	62.6ns	217ns	2	0	0	13.03 KB
master	AllCycleMoreComplexBody	netcoreapp3.1	182μs	633ns	2.45μs	0.0912	0	0	12.11 KB
master	ObjectExtractorSimpleBody	net472	281ns	0.0948ns	0.355ns	0.0574	0	0	361 B
master	ObjectExtractorSimpleBody	netcoreapp3.1	235ns	0.14ns	0.544ns	0.00367	0	0	272 B
master	ObjectExtractorMoreComplexBody	net472	15.6μs	9.25ns	35.8ns	1.21	0.0156	0	7.62 KB
master	ObjectExtractorMoreComplexBody	netcoreapp3.1	12.9μs	5.61ns	21.7ns	0.0897	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	24.8μs	77.4ns	300ns	0.277	0	0	1.78 KB
#2880	AllCycleSimpleBody	netcoreapp3.1	21.5μs	31.9ns	111ns	0.0213	0	0	1.65 KB
#2880	AllCycleMoreComplexBody	net472	195μs	755ns	2.92μs	2.01	0	0	13.03 KB
#2880	AllCycleMoreComplexBody	netcoreapp3.1	182μs	101ns	377ns	0.0911	0	0	12.11 KB
#2880	ObjectExtractorSimpleBody	net472	283ns	0.228ns	0.882ns	0.0574	0	0	361 B
#2880	ObjectExtractorSimpleBody	netcoreapp3.1	236ns	0.0852ns	0.319ns	0.0037	0	0	272 B
#2880	ObjectExtractorMoreComplexBody	net472	15.9μs	12.7ns	49.3ns	1.21	0.016	0	7.62 KB
#2880	ObjectExtractorMoreComplexBody	netcoreapp3.1	12.5μs	7.15ns	27.7ns	0.0871	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #2880

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1	1.145	276,786.40	317,021.78

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	279μs	1.63μs	15.2μs	0.149	0	0	20.96 KB
#2880	SendRequest	net472	0.000419ns	0.000286ns	0.00111ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	318μs	1.8μs	12.4μs	0.159	0	0	20.96 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.8μs	2.49ns	9.31ns	0.163	0.0018	0.000901	1.03 KB
master	ExecuteNonQuery	netcoreapp3.1	1.44μs	1.44ns	5.19ns	0.0138	0	0	1.02 KB
#2880	ExecuteNonQuery	net472	1.81μs	2.86ns	10.7ns	0.162	0.000897	0	1.03 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.41μs	2.66ns	10.3ns	0.014	0	0	1.02 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.51μs	0.551ns	1.91ns	0.196	0	0	1.24 KB
master	CallElasticsearch	netcoreapp3.1	1.52μs	0.32ns	1.24ns	0.0156	0	0	1.18 KB
master	CallElasticsearchAsync	net472	2.62μs	1.51ns	5.86ns	0.218	0	0	1.37 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.63μs	0.726ns	2.72ns	0.0171	0	0	1.3 KB
#2880	CallElasticsearch	net472	2.39μs	0.636ns	2.47ns	0.196	0	0	1.24 KB
#2880	CallElasticsearch	netcoreapp3.1	1.46μs	0.582ns	2.18ns	0.0162	0	0	1.18 KB
#2880	CallElasticsearchAsync	net472	2.65μs	0.708ns	2.65ns	0.218	0	0	1.37 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.53μs	0.719ns	2.59ns	0.0175	0	0	1.3 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.69μs	4.25ns	15.3ns	0.238	0	0	1.5 KB
master	ExecuteAsync	netcoreapp3.1	1.67μs	0.821ns	3.18ns	0.0192	0	0	1.42 KB
#2880	ExecuteAsync	net472	2.67μs	2.5ns	9.7ns	0.238	0	0	1.5 KB
#2880	ExecuteAsync	netcoreapp3.1	1.72μs	0.558ns	2.16ns	0.0189	0	0	1.42 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	7.15μs	2.21ns	8.26ns	0.556	0	0	3.51 KB
master	SendAsync	netcoreapp3.1	4.62μs	2.41ns	9.02ns	0.0441	0	0	3.21 KB
#2880	SendAsync	net472	7.21μs	2.33ns	9.02ns	0.556	0	0	3.51 KB
#2880	SendAsync	netcoreapp3.1	4.74μs	3.11ns	10.8ns	0.0427	0	0	3.21 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.65μs	1.16ns	4.02ns	0.301	0	0	1.9 KB
master	EnrichedLog	netcoreapp3.1	2.33μs	0.685ns	2.56ns	0.0257	0	0	1.93 KB
#2880	EnrichedLog	net472	2.66μs	0.956ns	3.58ns	0.302	0	0	1.9 KB
#2880	EnrichedLog	netcoreapp3.1	2.21μs	1.18ns	4.43ns	0.0265	0	0	1.93 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	150μs	104ns	403ns	0.746	0.224	0	4.74 KB
master	EnrichedLog	netcoreapp3.1	117μs	98.2ns	367ns	0.0584	0	0	4.58 KB
#2880	EnrichedLog	net472	148μs	86.7ns	336ns	0.741	0.222	0	4.74 KB
#2880	EnrichedLog	netcoreapp3.1	116μs	148ns	554ns	0.0583	0	0	4.58 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.48μs	1.94ns	7.25ns	0.582	0.00273	0	3.68 KB
master	EnrichedLog	netcoreapp3.1	4.27μs	3.65ns	13.7ns	0.0554	0	0	4 KB
#2880	EnrichedLog	net472	5.58μs	2.15ns	8.04ns	0.583	0.00278	0	3.68 KB
#2880	EnrichedLog	netcoreapp3.1	4.06μs	1.64ns	5.92ns	0.0546	0	0	4 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.19μs	2.54ns	9.85ns	0.23	0	0	1.45 KB
master	SendReceive	netcoreapp3.1	1.78μs	4.03ns	15.6ns	0.0184	0	0	1.4 KB
#2880	SendReceive	net472	2.12μs	0.615ns	2.3ns	0.23	0	0	1.45 KB
#2880	SendReceive	netcoreapp3.1	1.79μs	0.612ns	2.29ns	0.0188	0	0	1.4 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.61μs	1.74ns	6.51ns	0.366	0	0	2.32 KB
master	EnrichedLog	netcoreapp3.1	3.97μs	3.28ns	12.3ns	0.0257	0	0	1.89 KB
#2880	EnrichedLog	net472	4.65μs	1.3ns	4.85ns	0.367	0	0	2.32 KB
#2880	EnrichedLog	netcoreapp3.1	4μs	1.08ns	3.88ns	0.0242	0	0	1.89 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.12μs	0.303ns	1.17ns	0.141	0	0	891 B
master	StartFinishSpan	netcoreapp3.1	917ns	0.36ns	1.4ns	0.0115	0	0	840 B
master	StartFinishScope	net472	1.37μs	0.407ns	1.58ns	0.154	0	0	971 B
master	StartFinishScope	netcoreapp3.1	1.04μs	0.336ns	1.26ns	0.0129	0	0	960 B
#2880	StartFinishSpan	net472	1.1μs	0.439ns	1.7ns	0.141	0	0	891 B
#2880	StartFinishSpan	netcoreapp3.1	888ns	0.187ns	0.699ns	0.0111	0	0	840 B
#2880	StartFinishScope	net472	1.41μs	0.568ns	2.2ns	0.154	0	0	971 B
#2880	StartFinishScope	netcoreapp3.1	1.07μs	0.357ns	1.34ns	0.0128	0	0	960 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.44μs	0.462ns	1.79ns	0.154	0	0	971 B
master	RunOnMethodBegin	netcoreapp3.1	1.19μs	0.514ns	1.99ns	0.0129	0	0	960 B
#2880	RunOnMethodBegin	net472	1.39μs	0.363ns	1.31ns	0.154	0	0	971 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.16μs	0.375ns	1.4ns	0.0132	0	0	960 B

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• 2 benchmarks are faster, with geometric mean 1.243
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	771μs	1.13μs	4.39μs	0.383	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	551μs	572ns	2.22μs	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	773μs	834ns	3.23μs	0.386	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	567μs	419ns	1.62μs	0	0	0	2.63 KB

Benchmarks.Trace.AppSecBodyBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #2880

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net472	1.196	334.22	279.36

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	23.7μs	35ns	135ns	0.274	0	0	1.78 KB
master	AllCycleSimpleBody	netcoreapp3.1	23.9μs	131ns	776ns	0.0213	0	0	1.65 KB
master	AllCycleMoreComplexBody	net472	191μs	108ns	420ns	1.99	0	0	13.03 KB
master	AllCycleMoreComplexBody	netcoreapp3.1	180μs	624ns	2.42μs	0.0911	0	0	12.11 KB
master	ObjectExtractorSimpleBody	net472	334ns	0.0877ns	0.328ns	0.0573	0	0	361 B
master	ObjectExtractorSimpleBody	netcoreapp3.1	238ns	0.118ns	0.443ns	0.0037	0	0	272 B
master	ObjectExtractorMoreComplexBody	net472	15.8μs	11.3ns	43.9ns	1.2	0.0157	0	7.62 KB
master	ObjectExtractorMoreComplexBody	netcoreapp3.1	12.6μs	6.29ns	22.7ns	0.088	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	25.5μs	20.4ns	78.9ns	0.276	0	0	1.78 KB
#2880	AllCycleSimpleBody	netcoreapp3.1	23.2μs	134ns	1.14μs	0.0121	0	0	1.65 KB
#2880	AllCycleMoreComplexBody	net472	192μs	78ns	302ns	2.02	0	0	13.03 KB
#2880	AllCycleMoreComplexBody	netcoreapp3.1	179μs	603ns	2.34μs	0.0915	0	0	12.11 KB
#2880	ObjectExtractorSimpleBody	net472	279ns	0.0958ns	0.359ns	0.0573	0	0	361 B
#2880	ObjectExtractorSimpleBody	netcoreapp3.1	265ns	0.428ns	1.66ns	0.00372	0	0	272 B
#2880	ObjectExtractorMoreComplexBody	net472	16μs	15.8ns	61.3ns	1.2	0.016	0	7.62 KB
#2880	ObjectExtractorMoreComplexBody	netcoreapp3.1	13.1μs	5.97ns	23.1ns	0.0917	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #2880

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1	1.292	331,332.26	256,426.88

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	330μs	1.59μs	6.75μs	0.162	0	0	20.96 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	258μs	1.46μs	10.5μs	0.25	0	0	20.96 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.88μs	2.65ns	9.91ns	0.162	0.000933	0	1.03 KB
master	ExecuteNonQuery	netcoreapp3.1	1.45μs	2.39ns	9.27ns	0.0137	0	0	1.02 KB
#2880	ExecuteNonQuery	net472	1.83μs	2.62ns	10.2ns	0.162	0.000913	0	1.03 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.47μs	2.44ns	9.13ns	0.014	0	0	1.02 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.44μs	1.14ns	4.4ns	0.196	0	0	1.24 KB
master	CallElasticsearch	netcoreapp3.1	1.53μs	1.16ns	4.17ns	0.0155	0	0	1.18 KB
master	CallElasticsearchAsync	net472	2.57μs	1.56ns	6.05ns	0.217	0	0	1.37 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.61μs	4.06ns	15.2ns	0.0176	0	0	1.3 KB
#2880	CallElasticsearch	net472	2.5μs	0.745ns	2.69ns	0.196	0	0	1.24 KB
#2880	CallElasticsearch	netcoreapp3.1	1.5μs	0.644ns	2.41ns	0.0157	0	0	1.18 KB
#2880	CallElasticsearchAsync	net472	2.6μs	0.724ns	2.8ns	0.217	0	0	1.37 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.65μs	0.561ns	2.17ns	0.0174	0	0	1.3 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.69μs	1.3ns	5.05ns	0.238	0	0	1.5 KB
master	ExecuteAsync	netcoreapp3.1	1.7μs	0.527ns	1.83ns	0.0188	0	0	1.42 KB
#2880	ExecuteAsync	net472	2.57μs	1.08ns	4.17ns	0.238	0	0	1.5 KB
#2880	ExecuteAsync	netcoreapp3.1	1.75μs	0.562ns	2.03ns	0.0192	0	0	1.42 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	7.16μs	1.75ns	6.55ns	0.556	0	0	3.51 KB
master	SendAsync	netcoreapp3.1	4.59μs	1.5ns	5.82ns	0.0438	0	0	3.21 KB
#2880	SendAsync	net472	7.19μs	2.64ns	9.9ns	0.555	0	0	3.51 KB
#2880	SendAsync	netcoreapp3.1	4.74μs	2.34ns	9.04ns	0.0428	0	0	3.21 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.71μs	1.12ns	3.87ns	0.302	0	0	1.9 KB
master	EnrichedLog	netcoreapp3.1	2.26μs	0.824ns	3.08ns	0.0261	0	0	1.93 KB
#2880	EnrichedLog	net472	2.78μs	2.32ns	8.97ns	0.302	0	0	1.9 KB
#2880	EnrichedLog	netcoreapp3.1	2.32μs	1.05ns	4.05ns	0.0266	0	0	1.93 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	147μs	180ns	697ns	0.734	0.22	0	4.74 KB
master	EnrichedLog	netcoreapp3.1	117μs	106ns	397ns	0.0582	0	0	4.58 KB
#2880	EnrichedLog	net472	148μs	161ns	556ns	0.739	0.222	0	4.74 KB
#2880	EnrichedLog	netcoreapp3.1	117μs	117ns	422ns	0.0587	0	0	4.58 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.64μs	3.02ns	11.7ns	0.582	0.0028	0	3.68 KB
master	EnrichedLog	netcoreapp3.1	4.23μs	1.63ns	6.1ns	0.0549	0	0	4 KB
#2880	EnrichedLog	net472	5.43μs	1.61ns	6.25ns	0.583	0.0027	0	3.68 KB
#2880	EnrichedLog	netcoreapp3.1	4.2μs	2.4ns	9.31ns	0.0544	0	0	4 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.24μs	1.09ns	4.22ns	0.23	0	0	1.45 KB
master	SendReceive	netcoreapp3.1	1.73μs	1.17ns	4.53ns	0.0191	0	0	1.4 KB
#2880	SendReceive	net472	2.1μs	0.816ns	3.16ns	0.231	0	0	1.45 KB
#2880	SendReceive	netcoreapp3.1	1.83μs	0.427ns	1.54ns	0.0191	0	0	1.4 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.69μs	1.81ns	7ns	0.368	0	0	2.32 KB
master	EnrichedLog	netcoreapp3.1	3.99μs	4.24ns	16.4ns	0.0259	0	0	1.89 KB
#2880	EnrichedLog	net472	4.68μs	0.788ns	3.05ns	0.368	0	0	2.32 KB
#2880	EnrichedLog	netcoreapp3.1	3.87μs	1.56ns	5.84ns	0.0251	0	0	1.89 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.12μs	0.36ns	1.35ns	0.141	0	0	891 B
master	StartFinishSpan	netcoreapp3.1	938ns	0.276ns	1.03ns	0.0112	0	0	840 B
master	StartFinishScope	net472	1.39μs	0.504ns	1.88ns	0.154	0	0	971 B
master	StartFinishScope	netcoreapp3.1	1.01μs	0.42ns	1.63ns	0.0131	0	0	960 B
#2880	StartFinishSpan	net472	1.17μs	0.42ns	1.63ns	0.141	0	0	891 B
#2880	StartFinishSpan	netcoreapp3.1	898ns	0.281ns	1.09ns	0.0112	0	0	840 B
#2880	StartFinishScope	net472	1.34μs	0.863ns	3.34ns	0.154	0	0	971 B
#2880	StartFinishScope	netcoreapp3.1	1.1μs	0.318ns	1.19ns	0.0132	0	0	960 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.55μs	0.527ns	1.9ns	0.154	0	0	971 B
master	RunOnMethodBegin	netcoreapp3.1	1.16μs	0.345ns	1.34ns	0.0128	0	0	960 B
#2880	RunOnMethodBegin	net472	1.42μs	1.11ns	4.17ns	0.154	0	0	971 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.12μs	0.429ns	1.61ns	0.0128	0	0	960 B

[datadog-ddstaging[bot]]

Datadog Report

Branch report: shurivich/profiler_ci Commit report: 9f8c59f

:x: dd-trace-dotnet 1 Failed (1 Known Flaky), 0 New Flaky, 228334 Passed, 685 Skipped, 19m 24.27s Wall Time

:x: Failed Tests (1)

• WorkingWithContinuousProfiler - Datadog.Trace.Tools.Runner.IntegrationTests.Checks.ProcessBasicChecksTests - :snowflake: Known flaky - Details

  Expand for error

  imeout when waiting for the target process to start
  

[andrewlock]

Benchmarks Report :snail:

Benchmarks for #2880 compared to master:

• 1 benchmarks are faster, with geometric mean 1.133
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net472	765μs	556ns	2.15μs	0.383	0	0	3.22 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	560μs	404ns	1.46μs	0	0	0	2.63 KB
#2880	WriteAndFlushEnrichedTraces	net472	766μs	880ns	3.41μs	0.383	0	0	3.22 KB
#2880	WriteAndFlushEnrichedTraces	netcoreapp3.1	555μs	428ns	1.6μs	0	0	0	2.62 KB

Benchmarks.Trace.AppSecBodyBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #2880

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net472	1.133	25,413.95	22,424.95

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net472	25.4μs	13.1ns	50.7ns	0.279	0	0	1.78 KB
master	AllCycleSimpleBody	netcoreapp3.1	23.7μs	127ns	719ns	0.0214	0	0	1.65 KB
master	AllCycleMoreComplexBody	net472	192μs	58.5ns	226ns	2.01	0	0	13.03 KB
master	AllCycleMoreComplexBody	netcoreapp3.1	182μs	562ns	2.18μs	0.0892	0	0	12.11 KB
master	ObjectExtractorSimpleBody	net472	286ns	0.198ns	0.739ns	0.0574	0	0	361 B
master	ObjectExtractorSimpleBody	netcoreapp3.1	232ns	0.174ns	0.673ns	0.00373	0	0	272 B
master	ObjectExtractorMoreComplexBody	net472	15.9μs	13.1ns	47.3ns	1.21	0.0159	0	7.62 KB
master	ObjectExtractorMoreComplexBody	netcoreapp3.1	12.7μs	17.6ns	68.3ns	0.0883	0	0	6.75 KB
#2880	AllCycleSimpleBody	net472	22.5μs	73.1ns	273ns	0.276	0	0	1.78 KB
#2880	AllCycleSimpleBody	netcoreapp3.1	23.3μs	112ns	488ns	0.0212	0	0	1.65 KB
#2880	AllCycleMoreComplexBody	net472	192μs	133ns	481ns	2.02	0	0	13.03 KB
#2880	AllCycleMoreComplexBody	netcoreapp3.1	183μs	645ns	2.5μs	0.0925	0	0	12.11 KB
#2880	ObjectExtractorSimpleBody	net472	315ns	0.127ns	0.49ns	0.0573	0	0	361 B
#2880	ObjectExtractorSimpleBody	netcoreapp3.1	236ns	0.202ns	0.782ns	0.00376	0	0	272 B
#2880	ObjectExtractorMoreComplexBody	net472	15.6μs	10.6ns	39.8ns	1.2	0.0156	0	7.62 KB
#2880	ObjectExtractorMoreComplexBody	netcoreapp3.1	12.9μs	3.63ns	14.1ns	0.09	0	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
master	SendRequest	netcoreapp3.1	335μs	1.85μs	12μs	0.156	0	0	20.96 KB
#2880	SendRequest	net472	0ns	0ns	0ns	0	0	0	0 b
#2880	SendRequest	netcoreapp3.1	298μs	1.73μs	14.3μs	0.154	0	0	20.96 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net472	1.89μs	2.12ns	7.93ns	0.163	0.000931	0	1.03 KB
master	ExecuteNonQuery	netcoreapp3.1	1.39μs	2.42ns	9.05ns	0.0139	0	0	1.02 KB
#2880	ExecuteNonQuery	net472	1.9μs	1.61ns	5.81ns	0.163	0.00095	0	1.03 KB
#2880	ExecuteNonQuery	netcoreapp3.1	1.49μs	2.22ns	8.33ns	0.0134	0	0	1.02 KB

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net472	2.4μs	1.73ns	6.71ns	0.196	0	0	1.24 KB
master	CallElasticsearch	netcoreapp3.1	1.51μs	1.03ns	3.84ns	0.016	0	0	1.18 KB
master	CallElasticsearchAsync	net472	2.56μs	0.769ns	2.98ns	0.218	0	0	1.37 KB
master	CallElasticsearchAsync	netcoreapp3.1	1.67μs	2.44ns	9.13ns	0.0176	0	0	1.3 KB
#2880	CallElasticsearch	net472	2.35μs	1.37ns	5.31ns	0.196	0	0	1.24 KB
#2880	CallElasticsearch	netcoreapp3.1	1.56μs	1.24ns	4.63ns	0.0164	0	0	1.18 KB
#2880	CallElasticsearchAsync	net472	2.55μs	0.625ns	2.42ns	0.218	0	0	1.37 KB
#2880	CallElasticsearchAsync	netcoreapp3.1	1.65μs	0.642ns	2.4ns	0.0173	0	0	1.3 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net472	2.69μs	1.18ns	4.57ns	0.238	0	0	1.5 KB
master	ExecuteAsync	netcoreapp3.1	1.75μs	1.37ns	4.94ns	0.0193	0	0	1.42 KB
#2880	ExecuteAsync	net472	2.74μs	0.812ns	3.15ns	0.237	0	0	1.5 KB
#2880	ExecuteAsync	netcoreapp3.1	1.77μs	1.38ns	5.17ns	0.0194	0	0	1.42 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net472	7.36μs	13.5ns	52.4ns	0.557	0	0	3.51 KB
master	SendAsync	netcoreapp3.1	4.77μs	4.59ns	17.2ns	0.0439	0	0	3.21 KB
#2880	SendAsync	net472	7.22μs	1.97ns	7.62ns	0.555	0	0	3.51 KB
#2880	SendAsync	netcoreapp3.1	4.75μs	2.17ns	8.11ns	0.0428	0	0	3.21 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	2.83μs	3ns	11.6ns	0.302	0	0	1.9 KB
master	EnrichedLog	netcoreapp3.1	2.19μs	0.594ns	2.3ns	0.0262	0	0	1.93 KB
#2880	EnrichedLog	net472	2.72μs	4.55ns	17ns	0.302	0	0	1.9 KB
#2880	EnrichedLog	netcoreapp3.1	2.3μs	1.69ns	6.31ns	0.0265	0	0	1.93 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	147μs	84.7ns	328ns	0.734	0.22	0	4.74 KB
master	EnrichedLog	netcoreapp3.1	117μs	100ns	362ns	0.0581	0	0	4.58 KB
#2880	EnrichedLog	net472	147μs	45.9ns	172ns	0.738	0.221	0	4.74 KB
#2880	EnrichedLog	netcoreapp3.1	117μs	171ns	663ns	0	0	0	4.58 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	5.6μs	1.93ns	6.95ns	0.582	0.0028	0	3.68 KB
master	EnrichedLog	netcoreapp3.1	4.07μs	1.57ns	5.89ns	0.0546	0	0	4 KB
#2880	EnrichedLog	net472	5.5μs	1.27ns	4.93ns	0.583	0.00274	0	3.68 KB
#2880	EnrichedLog	netcoreapp3.1	4.15μs	2.21ns	8.26ns	0.0535	0	0	4 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net472	2.23μs	1.22ns	4.55ns	0.23	0	0	1.45 KB
master	SendReceive	netcoreapp3.1	1.77μs	0.434ns	1.62ns	0.0193	0	0	1.4 KB
#2880	SendReceive	net472	2.17μs	2.3ns	8.92ns	0.231	0	0	1.45 KB
#2880	SendReceive	netcoreapp3.1	1.79μs	0.45ns	1.74ns	0.0187	0	0	1.4 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net472	4.79μs	2.86ns	11.1ns	0.368	0	0	2.32 KB
master	EnrichedLog	netcoreapp3.1	3.9μs	3.87ns	15ns	0.0253	0	0	1.89 KB
#2880	EnrichedLog	net472	4.83μs	3.06ns	11.9ns	0.367	0	0	2.32 KB
#2880	EnrichedLog	netcoreapp3.1	3.84μs	2.92ns	10.9ns	0.0255	0	0	1.89 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net472	1.1μs	0.247ns	0.958ns	0.141	0	0	891 B
master	StartFinishSpan	netcoreapp3.1	941ns	0.337ns	1.26ns	0.0113	0	0	840 B
master	StartFinishScope	net472	1.31μs	0.322ns	1.2ns	0.154	0	0	971 B
master	StartFinishScope	netcoreapp3.1	1.01μs	0.316ns	1.18ns	0.0132	0	0	960 B
#2880	StartFinishSpan	net472	1.09μs	0.472ns	1.77ns	0.141	0	0	891 B
#2880	StartFinishSpan	netcoreapp3.1	888ns	0.247ns	0.892ns	0.0115	0	0	840 B
#2880	StartFinishScope	net472	1.33μs	0.36ns	1.35ns	0.154	0	0	971 B
#2880	StartFinishScope	netcoreapp3.1	1.05μs	0.906ns	3.39ns	0.013	0	0	960 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net472	1.52μs	0.56ns	2.17ns	0.154	0	0	971 B
master	RunOnMethodBegin	netcoreapp3.1	1.17μs	0.584ns	2.26ns	0.0128	0	0	960 B
#2880	RunOnMethodBegin	net472	1.46μs	0.332ns	1.29ns	0.154	0	0	971 B
#2880	RunOnMethodBegin	netcoreapp3.1	1.21μs	0.911ns	3.41ns	0.0132	0	0	960 B