Andrew Lock

Results 720 comments of Andrew Lock

Thanks @marspion - snapshot testing is a way of confirming the output is what you expect. It's using [this library, Verify](https://github.com/VerifyTests/Verify). [Dan Clarke has a good introduction to it here](https://www.danclarke.com/snapshot-testing-with-verify)....

>To be honest I wasn't able to verify all snapshot files. I randomly verified some of them (different combinations). Yeah, there's so many combinations now that's about the best we...

Nice work on the Mongo2Go @marspion. I was just looking through the serializer changes, and I'm not entirely sure whether the serializers are completely consistent? Should we handle nulls explicitly...

## Execution-Time Benchmarks Report :stopwatch: Execution-time results for samples comparing the following branches/commits: - [This PR (3142)](https://github.com/DataDog/dd-trace-dotnet/tree/822526ed4f9d7a6bb1e9a80035fca92879249205) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/cdfb80ca4f70bd9dbf789ae02fe4509d79615bd1) Execution-time benchmarks measure the whole time it takes to execute a...

## Benchmarks Report for tracer :snail: Benchmarks for #3142 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/cdfb80ca4f70bd9dbf789ae02fe4509d79615bd1): * 2 benchmarks are **faster**, with geometric mean 1.161 * 1 benchmarks are **slower**, with geometric mean 1.131...

## Throughput/Crank Report:zap: Throughput results for AspNetCoreSimpleController comparing the following branches/commits: - [This PR (3142)](https://github.com/DataDog/dd-trace-dotnet/tree/822526ed4f9d7a6bb1e9a80035fca92879249205) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/cdfb80ca4f70bd9dbf789ae02fe4509d79615bd1) - [benchmarks/2.9.0](https://github.com/DataDog/dd-trace-dotnet/tree/89ae3f4ee7d85b824badda5873166707c9e560b4) Cases where throughput results for the PR are worse than latest...

## Code Coverage Report :bar_chart: :heavy_check_mark: Merging #3321 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/2227ee143f60eb5842748c7e8beb0a5c89acfc96) will **not change** line coverage :heavy_check_mark: Merging #3321 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/2227ee143f60eb5842748c7e8beb0a5c89acfc96) will **not change** branch coverage :no_entry: Merging #3321 into [master](https://github.com/DataDog/dd-trace-dotnet/tree/2227ee143f60eb5842748c7e8beb0a5c89acfc96)...

## Benchmarks Report :snail: Benchmarks for #3321 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/23f2e59d2a184a1958333a909e46ecb82157249c): * All benchmarks have **the same** speed * All benchmarks have **the same** allocations The following thresholds were used for...

## Benchmarks Report :snail: Benchmarks for #3321 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/3a10ef8592fcf59a38bdf04ae97e1c18dcec6a78): * 1 benchmarks are **faster**, with geometric mean 1.140 * All benchmarks have **the same** allocations The following thresholds were...

## Benchmarks Report :snail: Benchmarks for #3321 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/3c9735b0925e9caaf5a5f274ec120c877c818203): * All benchmarks have **the same** speed * All benchmarks have **the same** allocations The following thresholds were used for...