Andreas Stefl

Results 188 comments of Andreas Stefl

I think I haven't seen this error in a long time

@Corentin-Allaire are you using the chain from [above](https://github.com/acts-project/acts/issues/1578#issue-1399271962)? otherwise if you could share the script I can try to verify

makes sense to me as the performance seems to be mostly lost in the ambi resolution which is not optimal anyway

@dimitra97 there is one clang tidy failure ``` ╭─ /builds/acts/ci-bridge/src/Core/include/Acts/Navigation/MultiLayerSurfacesU─╮ │ 🟡 │ │ /builds/acts/ci-bridge/src/Core/include/Acts/Navigation/MultiLayerSurfacesUp │ │ dater.hpp:128:24 WARNING [performance-unnecessary-value-param] │ │ ╭──────────────────────────────────────────────────────────────────────────╮ │ │ │ parameter 'startPosition' is passed...

I will hold this back until I can test this in Athena

Are the output changes coming from changes in particle properties like mass @paulgessinger ? Let's look at the new plots and check how big the variation is

physmon looks like outliers moved a bit - unproblematic from my side

After reintroducing the `farLimit` based on the aborter step size the physmon diff is calmed down and it looks like there are some minor efficiency improvements hinting that this fixed...

performance looks mostly identical ![image](https://github.com/acts-project/acts/assets/487211/03ec5ff2-66a6-4829-8d89-578a0593f5d4) ![image](https://github.com/acts-project/acts/assets/487211/b123f22e-edb4-4c3a-9ca5-10b0173a1ba9)

started implementing the proposed solution here https://github.com/acts-project/acts/pull/2865