acts-project
chore: Update ParticleDataTable.hpp
This updates the script to generate our particle data table from scikithep, and updates the table.
This also adds many many more PDG IDs, as scikithep particle was updated to include them. I'm wondering if at this point we should switch to using a std::map / binary search for these lookups.
Does clang-format do anything after generating the data base?
Maybe we should remove it? Since we don't expect any changes, an ill setup system could even mal-format the file.
This is not intended to be run very often, so I would say it's not super critical. I think it just makes sure the formatting is fine, because the generation script does not ensure this at all.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 49.06%. Comparing base (
3203649) to head (7050a1e). Report is 7 commits behind head on main.
:exclamation: Current head 7050a1e differs from pull request most recent head 52f0869. Consider uploading reports for the commit 52f0869 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #2908 +/- ##
==========================================
- Coverage 49.09% 49.06% -0.04%
==========================================
Files 497 495 -2
Lines 29155 28978 -177
Branches 13851 13740 -111
==========================================
- Hits 14314 14218 -96
- Misses 4908 4928 +20
+ Partials 9933 9832 -101
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
📊: Physics performance monitoring for 52f086956ec3d17d0f5281dd4c06c5f9d5127788
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Memory consumption of compiling this header file goes from 60M to 77M, which I think we can tolerate.
Are the output changes coming from changes in particle properties like mass @paulgessinger ? Let's look at the new plots and check how big the variation is
I haven't looked into this further. I'd wouldn't have expected masses to change actually but who knows.
@andiwand suggested in the dev-meeting:
- physmon is fine again, maybe just clash with different PR
- 1 hash changed, maybe because one of the masses changed. We should go with the updated mass.
Next step: @andiwand will update the hash
This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.
![kodiakhq[bot] avatar](https://avatars.githubusercontent.com/in/29196?v=4 "Published by a pub.dev verified publisher"){kind=small}
