acts
acts copied to clipboard
acts-project
refactor: Change the MultiLayerSurfacesUpdater to use the local position and direction
This PR introduces some changes in the MultiLayerSurfacesUpdater in order to consider the local position and direction from the navigation state and generates the path in the grid based on them. Also, since this Navigation Delegate is used in the MultiWireStructureBuilder I pass the transform of the multiLayer in the delegate, in order to be taken into account for the global->local transformations.
(I deleted a previous branch that I have created for this and created a new one, because I had messed up with some files from main)
Codecov Report
Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.
Project coverage is 48.83%. Comparing base (
3203649) to head (c73d299). Report is 4 commits behind head on main.
:exclamation: Current head c73d299 differs from pull request most recent head b40eb44. Consider uploading reports for the commit b40eb44 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #3041 +/- ##
==========================================
- Coverage 49.09% 48.83% -0.27%
==========================================
Files 497 491 -6
Lines 29155 28886 -269
Branches 13851 13709 -142
==========================================
- Hits 14314 14106 -208
- Misses 4908 4954 +46
+ Partials 9933 9826 -107
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
📊: Physics performance monitoring for b40eb44db07bc6acfc987e87577b9dd628f77eb2
physmon summary
- ✅ CKF truth_smeared
- ✅ IVF truth_smeared
- ✅ AMVF truth_smeared
- ✅ Track Summary CKF truth_smeared
- ✅ Seeding truth_estimated
- ✅ CKF truth_estimated
- ✅ IVF truth_estimated
- ✅ AMVF truth_estimated
- ✅ Track Summary CKF truth_estimated
- ✅ Seeding seeded
- ✅ CKF seeded
- ✅ IVF seeded
- ✅ AMVF seeded
- ✅ AMVF (+grid seeder) seeded
- ✅ Track Summary CKF seeded
- ✅ Seeding orthogonal
- ✅ CKF orthogonal
- ✅ IVF orthogonal
- ✅ AMVF orthogonal
- ✅ Track Summary CKF orthogonal
- ✅ Ambisolver seeded
- ✅ Ambisolver orthogonal
- ✅ Seeding ttbar
- ✅ CKF ttbar
- ✅ Ambisolver
- ✅ Track Summary CKF ttbar
- ✅ AMVF ttbar
- ✅ AMVF (+grid seeder) ttbar
- ✅ Truth tracking (GSF)
- ✅ Truth tracking
- ✅ Truth tracking (GX2F)
- ✅ Particles fatras
- ✅ Particles geant4
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dimitra97 there is one clang tidy failure
╭─ /builds/acts/ci-bridge/src/Core/include/Acts/Navigation/MultiLayerSurfacesU─╮
│ 🟡 │
│ /builds/acts/ci-bridge/src/Core/include/Acts/Navigation/MultiLayerSurfacesUp │
│ dater.hpp:128:24 WARNING [performance-unnecessary-value-param] │
│ ╭──────────────────────────────────────────────────────────────────────────╮ │
│ │ parameter 'startPosition' is passed by value and only copied once; │ │
│ │ consider moving it to avoid unnecessary copies │ │
│ │ 19 | Vector3 position = startPosition; │ │
│ │ | ^ │ │
│ │ | std::move( ) │ │
│ │ │ │
│ ╰──────────────────────────────────────────────────────────────────────────╯ │
│ ──────────────────────────────────────────────────────────────────────────── │
╰──────────────────────────────────────────────────────────────────────────────╯
