refactor: Introduce `CurvilinearSurface`

[andiwand]

I noticed that the concept of a curvilinear surface is a quite spread over the codebase and I wanted to improve this. Here I introduce a surface like class which does not actually inherit from Acts::Surface but shares some of the functionality. This way the jacobians are put in a single place and can be used from somewhere else in an expressive fashion.

Afterwards it might make sense to let the CurvilinearTrackParameters depend on this special surface instead of a PlaneSurface or to merge them with BoundTrackParameters completely.

related issues

• #2812

blocked by

• https://github.com/acts-project/acts/pull/2789
• https://github.com/acts-project/acts/pull/2782
• https://github.com/acts-project/acts/pull/2781
• https://github.com/acts-project/acts/pull/2811

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 22.53521% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 49.11%. Comparing base (3203649) to head (adc6e1d).

Files	Patch %	Lines
Core/src/Surfaces/CurvilinearSurface.cpp	20.68%	20 Missing and 26 partials :warning:
Core/src/Propagator/detail/JacobianEngine.cpp	0.00%	0 Missing and 3 partials :warning:
...ts/EventData/GenericCurvilinearTrackParameters.hpp	0.00%	0 Missing and 2 partials :warning:
...e/include/Acts/EventData/detail/TestTrackState.hpp	0.00%	0 Missing and 2 partials :warning:
Core/include/Acts/Surfaces/CurvilinearSurface.hpp	80.00%	0 Missing and 1 partial :warning:
Core/src/Surfaces/PlaneSurface.cpp	0.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2814      +/-   ##
==========================================
+ Coverage   49.09%   49.11%   +0.02%     
==========================================
  Files         497      499       +2     
  Lines       29155    29152       -3     
  Branches    13851    13830      -21     
==========================================
+ Hits        14314    14319       +5     
- Misses       4908     4928      +20     
+ Partials     9933     9905      -28     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[github-actions[bot]]

📊: Physics performance monitoring for adc6e1d61e44cdb4f8cd6f8afd4f687c692fd076

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[acts-project-service]

:white_check_mark: Athena integration test results

:white_check_mark: All tests successful

status	job	report

[andiwand]

I will hold this back until I can test this in Athena