Alya Abbott

Results 1722 comments of Alya Abbott

Other than that, looks good to me in manual testing -- thanks, @Joelute !

I was thinking maybe matching the amount of space we have on the right, which is perhaps a bit less space than in your top screenshot? Or even less space...

Sure, the 14px seems reasonable; we can tweak it later with feedback from more folks. Please let me know when you've updated the PR accordingly. Thanks!

Thanks! Looks good to me in manual testing. @amanagr could you please review this PR?

> Overlapping message_content with icons: Hm, when do you get overlap like that? I don't think we want buttons and content to overlap.

@amanagr Would you be up for doing the first round of review on this one?

@Joelute Please clean up your commit history and post again to request a review. See https://zulip.readthedocs.io/en/latest/contributing/version-control.html. Thanks!

It looks like this point still needs to be addressed? > It should pass tests (so test updates needed by a change should be in the same commit as the...

Thanks! The vertical alignment (and maybe the sizing?) of the icons looks off to me. In this PR: ![Screen Shot 2023-01-24 at 9 42 30 AM](https://user-images.githubusercontent.com/2090066/214368812-a9f5e648-6286-47d3-83a0-90aae157aafe.png) Without this PR: ![Screen...

@amanagr Please take another look at this one when you get a chance -- thanks!