Alya Abbott

Results 1722 comments of Alya Abbott

Looks like you need to rebase the PR and renumber the migrations. I'm seeing this when I provision: ``` Conflicting migrations detected; multiple leaf nodes in the migration graph: (0433_stream_push_notifications_enabled,...

> @alya do you want to have a look again? Just a note that, this PR has been updated to disable the setting when push notifications are not configured on...

For some reason I'm getting errors when I change the time zone, which I'm not seeing on `main`:

OK, got it. Testing the PR again, it looks all right to me. @timabbott This has been reviewed by @sahil839 and me -- please take a look. The errors above...

@timabbott marking for integration review based on the comment thread; I have not reviewed.

@SameepAher Could you please show what the hover box is for the "edit" button? I think we want it bigger than in this PR; the button feels a bit hard...

Yeah, let's make it centered around the button, but larger than it currently is. Can you please post an updated screenshot when it's been updated?

Feels reasonable to me in manual testing now.

@Joelute Please add screenshots to the PR description for easy reference.

We should make sure to always leave space between the topic name and "new", including for long topics: ![Screen Shot 2022-11-21 at 5 36 53 PM](https://user-images.githubusercontent.com/2090066/203195813-31231f38-74d7-47e4-b40a-4c024cc52fe6.png) Could you please fix...