Alya Abbott
Alya Abbott
Thanks! I don't want to dig through the comment thread -- what happened to the documentation commit (https://github.com/prakhar1144/zulip/commit/c193fd419f833908772eca689c708ec694f0874f) you had before?
Assuming it hasn't been merged, you can put it up as a new PR, and I'll use that as a starting point.
> The very first UI thing we'll need to do after merging the API will be to add an option to the topic actions popover in the left sidebar called...
Thanks! Playing with the PR, I think we are going to need a custom banner after all, as otherwise the explanation of why messages aren't being marked as read seems...
Yes, of course, that's intentional.
Nice, looks good to me in manual testing! @amanagr Could you please review this PR?
> Currently the logic is to continue display the preserve reading state banner just like how it is currently (E.g. marking messages as unread, in a near message view, in...
Please rebase this PR and renumber the migrations. I'm seeing: ``` Conflicting migrations detected; multiple leaf nodes in the migration graph: (0433_add_do_not_mark_messages_as_read_setting, 0434_create_nobody_system_group in zerver). To fix them run 'python...
Works for me! @timabbott This PR has been reviewed by @amanagr and me -- please take a look.
@Joelute Would you like to take a pass at adding desktop/web instructions to http://zulip.com/help/marking-messages-as-read#configure-whether-messages-are-automatically-marked-as-read. We'll need to do that either in this PR or as an immediate follow-up, as otherwise...