Alya Abbott
Alya Abbott
Yeah, I think I agree with @amanagr 's comments based on the screen shot.
What will happen if one of the button labels is too long to fit in another language?
Usually we have enough room for buttons to be as wide as needed. Otherwise, things can wrap onto a new line (which probably wouldn't look good here), or be abbreviated....
Thanks! I found one behavior in manual testing that I think needs to be changed: 1. Unsubscribe a user from a stream 2. Turn on the new default notification setting...
Let's also rename the setting to "Mobile push notifications enabled by default", and give it more vertical space above, so that it's clear that it's not related to the retention...
Ah, hm, I see -- could you please ask for feedback on this question in the development community by starting a thread in #design?
Thanks! Let's add the same warning we have near the personal stream notification settings in the case when notifications are not configured on the server: ![Screen Shot 2023-01-30 at 10...
I think we can have leave the stream setting toggleable even when notifications aren't enabled on the server, but leaving this note here in case other reviewers have feedback on...
Once you've implemented the change above, please ping @sahil839 for a review.
> I am not sure whether we want tooltip on `i` icon or while hovering over the whole setting element (i.e. input and label) when push notifications are not configured...