Allen Pestaluky

Results 59 comments of Allen Pestaluky

Alright, I understand what's happening now and I might have a fix(?) Here are the details: I am going to use the `Dictionary` class for this example, as that is...

Thanks @dsnopek! Unfortunately it looks like this method leaks (it leaves an `ArrayPrivate` in memory with a refcount of 1). I'm going to look into why this is, probably tomorrow.

Oh, sorry, my mistake on my comment — I adapted your PR code to `Array`, since that’s what I’ve been testing with, so that’s why I typed that. So I...

I've tried the original post's minimal reproduction project with the [4.2.2 godot-cpp release](https://github.com/godotengine/godot-cpp/releases/tag/godot-4.2.2-stable) and: Godot v4.2.2.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 980 Ti (NVIDIA;...

> >Color may store linear values or nonlinear sRGB values. The problem is that it can be difficult to know if the data within Color is encoded as linear or...

> I want this, but maybe the idea of treating Color as SrgbColor and inventing a new LinearColor might be compatibility feasible. I think of adding a new Variant type...

> How does other software _in general_ handle all of this? Typically a programming context is initialized with an encoding format. Or, if it is the global context, a single...

Additionally, Unity has (or had?) a global project setting to switch between "gamma" and linear lighting calculations for 3D rendering. Unity's approach is [complicated](https://docs.unity3d.com/Manual/color-spaces-landing.html) as it suffers from some of...

> I think it's not bad to add a 32-bit srgb Color32, and the current Color should only use linear encoding. Then we can replace the Color with Color32 as...

Besides nonlinear piecewise sRGB encoding, other working spaces could include `log base 2`, `log base 2, scaled to middle grey of 0.18`, `normalized log2` and possibly some others. Again, these...