Allen Pestaluky comments

Results 14 comments of


                                            Allen Pestaluky

ResourceSaver.save() writes null for sub-resources that refer to each other

I've trimmed down the minimum repro a bit: Custom resource script: ```GDScript class_name MyResource extends Resource @export var my_resource_export : MyResource ``` Test script: ```GDScript extends Node func _ready() ->...

ResourceSaver.save() writes null for sub-resources that refer to each other

I have taken a brief look at the source code to see if I could improve the error message to let the developer know that there might be a circular...

Add detail and code examples to C++ Variant / Array / Dictionary page

When looking through some old issues, I noticed #7248 has some notes that are related to this issue.

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

I think the array is being corrupted with the current state of this PR... Here's my test code: ```C++ void GDExample::test_memory_behaviour() { UtilityFunctions::print("GDExtension::test_memory_behaviour()..."); { Array original_array; original_array.push_back(123); { Variant my_variant...

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

Oh, yeah, at first glance, this looks 1000x better than the other PR. Nicely done! Thanks! I've tried testing this with my boiled down minimum reproduction code as well as...

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

> There's a few types where we could avoid initializing them to their defaults, such as `Vector2/3/i` and `Transform2D/3D`, but those classes are hand-written and don't call into Godot for...

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

> Makes sense! I've added a `@todo` comment in the conversion methods where we could consider avoiding the extra initialization in the future. Thanks! That leaves only the following untouched,...

[DRAFT] Avoid creating objects that Godot is going to use placement new to initialize (mark 2)

I've been using this PR in my fork of godot-cpp for a week or so and haven't discovered any instabilities with it.

Accessing Dictionary from inside of Array results in a memory leak

System Info: - Godot v4.2.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 980 Ti (NVIDIA; 31.0.15.3598) - 13th Gen Intel(R) Core(TM) i7-13700K (24 Threads) - GDExtension...

Accessing Dictionary from inside of Array results in a memory leak

It's possible this leak has some similarities to a chain of leaks from way back when ( https://github.com/godotengine/godot-cpp/pull/490 https://github.com/godotengine/godot-cpp/pull/356 https://github.com/godotengine/godot-cpp/pull/355). Is it possible some of these sorts of issues were...