Andrew Lamb

Results 1597 comments of Andrew Lamb

🤔 CI seems to have failed here: https://github.com/apache/arrow-datafusion/actions/runs/8327813127/job/22786403043?pr=9659 ``` Run cargo msrv verify Fetching index Verifying the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu Using check command cargo check...

Looks like we never formalized the MSRV discussion in https://github.com/apache/arrow-datafusion/issues/9082 -- I will make a PR to do so now Update: https://github.com/apache/arrow-datafusion/pull/9681

related to https://github.com/apache/datafusion/issues/6747 (for window APIs)

https://github.com/apache/datafusion/pull/10560 is looking sweet to me

I think @peter-toth plans to break this PR up into smaller ones, so marking it as a draft to make it clear it isn't waiting on more feedback. If I...

I am starting the benchmark run now -- I'll report back here and give this PR a look as soon as possible (but maybe not until tomorrow) Thank you so...

My results appear consistent with yours @peter-toth -- looks like maybe the high column count case is slightly worse -- I can maybe profile it to see if I can...

I ran the benchmarks again: Looks to me like this PR makes planning 10% faster ``` physical_plan_tpcds_all 1.00 1074.8±5.94ms ? ?/sec 1.10 1181.1±6.54ms ? ?/sec physical_plan_tpch_all 1.00 72.2±0.77ms ? ?/sec...

🚀 thanks again @peter-toth

@jayzhan211 asks https://github.com/apache/datafusion/issues/10374#issuecomment-2111340945 > > @alamb Do you think we should also rewrite the array operator to function in parser step? It is currently in optimizer step. I think the...