Andrew Lamb comments

Results 1766 comments of


                                            Andrew Lamb

chore(deps): bump apache-avro from 0.17.0 to 0.18.0

@dependabot recreate

Document how to test examples in user guide, add some more coverage

Thanks @efredine, this is great feedback > To perhaps provide more guidance on when on when an example should be included in the documentation? Yes, I agree this would be...

Document how to test examples in user guide, add some more coverage

> By pre-conditions I meant that in order to test or illustrate something like an option when reading a file I need to first create a file and write to...

Document how to test examples in user guide, add some more coverage

Thank you for your review (as always @comphead ) 🙏

Extract CSE logic to `datafusion_common`

FYI @andygrove -- CSE on physical plans is happening

Extract CSE logic to `datafusion_common`

I ran the benchmarks and there is no change in performance 🚀 ``` ++ critcmp main extract-cse-logic group extract-cse-logic main ----- ----------------- ---- logical_aggregate_with_join 1.01 1420.8±40.68µs ? ?/sec 1.00 1408.6±14.31µs...

Fix logical vs physical schema mismatch for right side field schema selection.

Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look

Fix logical vs physical schema mismatch for right side field schema selection.

I filed https://github.com/apache/datafusion/issues/13010 specifically to track this issue so we don't lose track of it

Fix logical vs physical schema mismatch for right side field schema selection.

Thanks again @itsjunetime and @wiedld

NoSuchMethodError: java.lang.Object org.apache.spark.executor.TaskMetrics.withExternalAccums(scala.Function1)

> @andygrove @alamb would y'all be able to help here? I saw that the prebuilt JARs were tested for 3.5.4 and upwards. Are they backwards compatible? Sorry I don't know...