Andrew Lamb

This looks super cool @jayzhan211

THanks @jayzhan211 -- I will plan to review this tomorrow.

> I'm not sure if we really need the error check since we don't have any now I guess what I was thinking is that the reason there is no...

> > I have some ideas about additional comments / documentation that I would be happy to help add > > Sure! Thank you for your patience @jayzhan211 -- I...

Thanks @Blizzara -- I started the CI on this PR

I agree with @berkaysynnada in https://github.com/apache/datafusion/pull/10543#issuecomment-2115389289 that in an ideal world we woul change `TreeNode::visit` and `TreeNode::apply`, however as @peter-toth notes this would: 1. Be a much larger change (and...

What do we think about merging this PR and filing a follow on ticket to unify the APIs?

I hope to review this PR later today or tomorrow

Awesome! I plan to merge this PR tomorrow unless anyone else would like time to review.

I filed https://github.com/apache/datafusion/issues/10678 to handle visit_with_subqueries I am waiting to merge this PR until the CI is fixed on main https://github.com/apache/datafusion/pull/10677