datafusion icon indicating copy to clipboard operation
datafusion copied to clipboard

Use stabalized aws-sdk and clap versions in `datafusion-cli`

Open satyakommula96 opened this issue 1 year ago • 5 comments

Which issue does this PR close?

with the latest changes from the main branch and open a new pull request

previous #8681

Closes #.

Rationale for this change

What changes are included in this PR?

Bump datafusion-cli dependencies use stabilized version aws-sdk 1.x.x (https://www.infoworld.com/article/3711271/aws-delivers-aws-sdk-for-rust.html) use latest clap version

Are these changes tested?

yes

Are there any user-facing changes?

satyakommula96 avatar Mar 18 '24 05:03 satyakommula96

please review @alamb @comphead

satyakommula96 avatar Mar 18 '24 05:03 satyakommula96

🤔 CI seems to have failed here: https://github.com/apache/arrow-datafusion/actions/runs/8327813127/job/22786403043?pr=9659

Run cargo msrv verify
Fetching index
Verifying the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu
Using check command cargo check
   Failed check command cargo check didn't succeed
Crate source was found to be incompatible with its MSRV '1.72.1', as defined in '/__w/arrow-datafusion/arrow-datafusion/datafusion-cli/Cargo.toml'
Error: Process completed with exit code 1.

alamb avatar Mar 18 '24 14:03 alamb

ouch, MSRV failed. https://github.com/smithy-lang/smithy-rs/blob/main/rust-toolchain.toml they require 1.74 and we support 1.72.

The latest rustc is 1.76 and we agreed I think to keep MSRV to be 4 versions behind

comphead avatar Mar 18 '24 17:03 comphead

Looks like we never formalized the MSRV discussion in https://github.com/apache/arrow-datafusion/issues/9082 -- I will make a PR to do so now

Update: https://github.com/apache/arrow-datafusion/pull/9681

alamb avatar Mar 18 '24 18:03 alamb

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 21 '24 01:05 github-actions[bot]