Andrew Lamb

Results 1970 comments of Andrew Lamb

I was thinking about this last night -- what I would suggest for this is to make functions like this for each type of https://docs.rs/parquet/latest/parquet/file/statistics/struct.ValueStatistics.html ```rust /// Returns an iterator...

marking as draft to show this PR isn't waiting for review

I think the tests in this PR add value as they function as an end to end test of statistics calculation and propagation -- perhaps we can move them to...

@samuelcolvin can you share the query plan for this query? Specifically what is the output of this query? ```sql explain select span_name from records order by bit_length(attributes) desc limit 20...

🤔 that certainly seems like it is doing a Top(K) with 14 cores -- so I would expect this would hold at most 20 * 14 batches * 20 is...

> Is it possible this memory issue is related to `bit_length` only? Maybe we can support string view for `bit_length` then test it again I think this was recently merged...

I skimmed through the commentary on this PR -- and it wasn't immediately clear to me what the current plan is. Are we agreed on a different approach? Are we...

Marking as a draft as I am trying to work through the review queue -- lets mark it as ready for review when it is ready for another look

Nice! So shall we close this ticket? Or is there still more work to do?