Andy Gocke

Results 208 comments of Andy Gocke

To record some thoughts from Teams before I forget: Right now Build Analysis is of limited usefulness because it only captures test success/failure at the Helix workitem granularity, which is...

@nblumhardt Thanks, sorry for the delay, took a little digging to track this down. The remaining errors appear to be caused by a bug and an unimplemented feature, both of...

No longer relevant, as https://learn.microsoft.com/en-us/dotnet/core/compatibility/deployment/8.0/rid-asset-list is now the default in .NET 8.

I'm closing new RID PRs for now, until we can sort out the RID plan, as in https://github.com/dotnet/runtime/pull/81115

Yeah, I don't think this is necessary now. We can bring it back if we need to.

I think this is mostly obsoleted by my write-up in https://gist.github.com/agocke/dea8adbe105101b6a397925c6984428b I do think we should translate that into a spec when we're ready to spec ref fields.

FYI, we're doing a lot of this with `RequiresUnreferencedCode`, `RequiresAssemblyFiles`, and `RequiresDynamicCode` for the runtime. I love this direction and I think it would be great if we had a...

PolySharp is currently missing RequiresAssemblyFiles (https://github.com/Sergio0694/PolySharp/issues/65) but the author is very responsive, so I'll wait for them to add it and then I'll pull in a new version.

I should also mention -- it's worth considering if this space should have an AOT-compatible solution. I think a source generator would probably be necessary.

This is a good point -- I was thinking that theoretically you could use a source generator to parse the file, and then construct an equivalent graph at compile time....